GNOME Bugzilla – Bug 631526
loading images doesn't use proxy credentials
Last modified: 2010-10-21 07:30:16 UTC
If you have evolution configured to use a proxy, when you load images (ctrl-i for example) it doesn't use the proxy credentials. Ideally it would use GSS/Negotiate, if available, but if not, it should use the same sort of proxy authentication that is now working for caldav. You know, it should be alarming that this needs fixing in multiple places. All of evolution should be using the same code for all proxy access, then these problems wouldn't need fixing forty-eleven times. I'm guessing you know that though. :-)
Hi. I suppose you have applied patch from bug #615274, but I'm asking anyway, because image loading is using this change too, only through CamelHttpStream. Is it possible the username is used, but not the password? I see that em_utils_get_proxy_uri uses soup_uri_to_string, which doesn't include passwords in the resulting string, so that might be the root of the problem.
Created attachment 172847 [details] [review] proposed evo patch for evolution; Could you try with this patch, please? I may work with it, seems to me. Thanks in advance.
(In reply to comment #1) > Hi. I suppose you have applied patch from bug #615274, but I'm asking anyway, Damn. Glad you are asking. I used to have it applied before I updated to Maverick but I am now trying to use (and help them with fixing) their 2.30.3 release so I am back to 2.30.3 (from gnome-2-30) plus whatever patches they/we apply. I will nominate this one for application. In the meanwhile I have applied it to my e-d-s and it's rebuilding at the moment. > because image loading is using this change too, only through CamelHttpStream. Perhaps this is the only reason, although I am pretty sure I filed this bug while I was on gnome-2-30 which would have included that fix. > Is it possible the username is used, but not the password? Even without bug 615274 applied, yes, this is exactly the case. > I see that > em_utils_get_proxy_uri uses soup_uri_to_string, which doesn't include passwords > in the resulting string, so that might be the root of the problem. I see.
(In reply to comment #2) > Created an attachment (id=172847) [details] [review] > proposed evo patch > > for evolution; > > Could you try with this patch, please? I may work with it, seems to me. > Thanks in advance. Do you still think this is needed provided the info in comment #2? I will try a build with bug 615274 applied and without the above patch applied first and see if just that resolves it. If not, I will apply the above patch and try also.
So, the results are that the patch from bug 615274 is not enough to make this work, but the patch in attachment 172847 [details] [review] do make it work. Awesome!
Thanks for testing this. I'm pushing this to sources.
Created commit c8a922e in evo master (2.91.2+) Created commit 20c9cc1 in evo gnome-2-32 (2.32.1+)