After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 631465 - Daemon started with --login should exit after a timeout
Daemon started with --login should exit after a timeout
Status: RESOLVED FIXED
Product: gnome-keyring
Classification: Core
Component: general
2.30.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
: 593772 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-10-05 19:39 UTC by Josselin Mouette
Modified: 2010-12-13 10:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed implementation (1.08 KB, patch)
2010-10-05 20:36 UTC, Josselin Mouette 		none Details | Review
Proposed implementation (1.70 KB, patch)
2010-10-05 21:04 UTC, Josselin Mouette 		none Details | Review

Description Josselin Mouette 2010-10-05 19:39:58 UTC 
When the daemon is started by the PAM module, it might not be used at all if the daemon is not started later in the session. It just remains here doing nothing.

This is a problem if you log in to a non-gnome session. It also happens when you use a GDM flexible server to log in to an already started session. The PAM module starts the daemon again, but it is never used since just after that, GDM just uses switchvt to send you to the VT where the existing session lies.
Comment 1 Josselin Mouette 2010-10-05 20:36:58 UTC 
Created attachment 171789 [details] [review]
Proposed implementation

This naive patch adds a 10-seconds timeout which exits if it hasn’t been initialized in the meantime.
Comment 2 Josselin Mouette 2010-10-05 21:04:53 UTC 
Created attachment 171790 [details] [review]
Proposed implementation

Cosmetic improvement: don’t wake up after 10 seconds if unnecessary.
Comment 3 Stef Walter 2010-10-19 02:21:04 UTC 
Committed with a higher timeout.

commit bb033e7513ec8123124e5e57c82c0ede029eda74
Author: Josselin Mouette <joss@malsain.org>
Date:   Tue Oct 19 02:09:49 2010 +0000

    [daemon] Add timeout if PAM startup doesn't complete shortly.
    
    When the daemon is started by the PAM module, it might not be used at all if
    the daemon is not started later in the session.
Comment 4 Stef Walter 2010-12-13 10:11:44 UTC 
*** Bug 593772 has been marked as a duplicate of this bug. ***