After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 631398 - Port gapplookupgconf.c to using x-scheme-handler/
Port gapplookupgconf.c to using x-scheme-handler/
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks: 631410 631433
 
 
Reported: 2010-10-05 10:26 UTC by Bastien Nocera
Modified: 2010-11-12 16:02 UTC
See Also:
GNOME target: 3.0
GNOME version: ---

Attachments
Remove app lookup extension (11.53 KB, patch)
2010-10-05 13:13 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2010-10-05 10:26:34 UTC 
When asked for the app supporting scheme "foo", it should look for the app handling mime-type "x-scheme-handler/foo" instead.
Comment 1 Matthias Clasen 2010-10-05 12:55:20 UTC 
I think we want that in gio itself, and ditch the gconf lookup thing
Comment 2 Bastien Nocera 2010-10-05 13:13:27 UTC 
Created attachment 171764 [details] [review]
Remove app lookup extension

Now done in GIO itself
Comment 3 Bastien Nocera 2010-10-05 16:20:35 UTC 
Attachment 171764 [details] pushed as e868c0c - Remove app lookup extension
Comment 4 Fryderyk Dziarmagowski 2010-11-03 17:58:36 UTC 
This patch is incomplete, min. required gio version should be here as well.
Comment 5 Bastien Nocera 2010-11-04 12:03:20 UTC 
(In reply to comment #4)
> This patch is incomplete, min. required gio version should be here as well.

Why? We're actually doing less work, not more. The code we removed doesn't need compiling...
Comment 6 Jan de Groot 2010-11-04 13:57:26 UTC 
The minimum required GIO version should be bumped because this patch removes features that were present in the old version when compiling with GIO from glib 2.26. Stable glib doesn't have the required changes for this, resulting in loss of functionality.

Right now I have a GNOME 2.32 desktop that opens HTTP URLs with firefox while Epiphany is my default browser setup in gnome-default-application-properties.
Comment 7 Cosimo Cecchi 2010-11-04 14:06:49 UTC 
I pushed this to gvfs master

http://git.gnome.org/browse/gvfs/commit/?id=9eac8436f165bdb1a4aac99a742f2e85d6866f90
Comment 8 Jan de Groot 2010-11-04 14:08:18 UTC 
Looks good. Could you revert this commit from the 1.6 branch and add it to master aswell? I don't think 1.6.x which are stable releases, should depend on 2.27.x code.
Comment 9 Cosimo Cecchi 2010-11-04 16:22:47 UTC 
There's no gnome-2-32 stable branch for GVfs, and the commit is on master only.
Comment 10 Tomas Bzatek 2010-11-12 16:02:24 UTC 
(In reply to comment #8)
> Looks good. Could you revert this commit from the 1.6 branch and add it to
> master aswell? I don't think 1.6.x which are stable releases, should depend on
> 2.27.x code.

I've created stable gnome-2-32 branch, reverted the commit and am going to roll 1.6.6 release. This should solve all your concerns. Master branch continues with Cosimo's change.