After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 631390 - dfbvideosink does not consider surfaces when blit is not accelerated
dfbvideosink does not consider surfaces when blit is not accelerated
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.14
Other Linux
: Normal normal
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-10-05 09:40 UTC by Tom Deseyn
Modified: 2011-05-30 06:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (5.56 KB, application/octet-stream)
2010-10-05 09:40 UTC, Tom Deseyn 		  Details
diff -u patch (902 bytes, patch)
2010-10-05 11:25 UTC, Tom Deseyn 		none Details | Review
diff -u patch (4.60 KB, patch)
2010-10-05 13:19 UTC, Tom Deseyn 		committed Details | Review

Description Tom Deseyn 2010-10-05 09:40:00 UTC 
Created attachment 171745 [details]
patch

When I 'gst-launch videotestsrc ! dfbvideosink' the pipeline fails because non of the surfaces have accelerated blitting.

The attached patch solves the problem by considering both accelerated and non-accelerated surfaces. The former are prefered.

Wkr,

Tom
Comment 1 Tom Deseyn 2010-10-05 11:25:41 UTC 
Created attachment 171754 [details] [review]
diff -u patch
Comment 2 Tom Deseyn 2010-10-05 13:19:05 UTC 
Created attachment 171765 [details] [review]
diff -u patch
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2011-02-28 14:50:42 UTC 
Looks good, but I can't test it myself. A git formatted patch would be nice.
Comment 4 Sebastian Dröge (slomo) 2011-05-30 06:49:16 UTC 
commit 8f7183dc8539b87033b69fab4c98e0f57f44b2be
Author: Tom Deseyn <tom.deseyn@barco.com>
Date:   Mon May 30 08:48:29 2011 +0200

    dfbvideosink: Also consider non-accelerated DirectFB surfaces
    
    Fixes bug #631390.