After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 631388 - Add gconf key to disable automatic xrandr settings without conf files
Add gconf key to disable automatic xrandr settings without conf files
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: xrandr
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on: 631502
Blocks:
 
 
Reported: 2010-10-05 08:49 UTC by Martin Pitt
Modified: 2010-11-05 16:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
RANDR - Add gconf key for disabling boot time configuration (3.77 KB, patch)
2010-10-05 09:41 UTC, Martin Pitt
committed Details | Review

Description Martin Pitt 2010-10-05 08:49:20 UTC
In https://launchpad.net/bugs/640807 we got a lot of reports that starting with 2.31.91 (which introduced automatic xrandr settings when there are no configuration files) a lot of people get misconfigured monitors. Examples:

 * Monitor is at 60 Hz, while X.org correctly configures it at 75.
 * External monitor is changed from native 1280x1024 (as set up by X.org) to 1024x768
 (and variations)

Even for situations where the current behaviour does not actually change the X.org settings it is undesirable in the general case to change the xrandr settings. In a KMS world, we want exactly one mode change when the kernel starts up, and then never again. Any further mode changes do not only introduce flicker, but also introduce significant boot time delays in the order of 1 or 2 seconds.

Frederico introduced this for various reasons, and some OEMs want this, but I think it should be configurable, and thus become a distro choice. This was recently discussed on IRC:

"<federico1> I'll happily include a patch that makes the boot-time configuration conditional
 <federico1> with some use_boot_time_configuration key or something reasonably-named
 <federico1> use_boot_time_configuration or use_xorg_configuration (the reverse)?
<federico1> I'd like it to be obvious from the key name that it's an either/or thing
<federico1> tormod: I'm leaning toward a do-not-touch kind of name now, with False by default - if you need to make it True, it means that you have a special case due to your X setup anyway"

I would like to work on a patch which introduces such a gconf key. By Frederico's comments it sounds like he prefers "use_boot_time_configuration"?
Comment 1 Martin Pitt 2010-10-05 09:03:32 UTC
Seb just said that Federico meant it the other way round -- have a gconf key that, when _enabled_, disables apply_default_boot_configuration(). Thus this would be "use_xorg_monitor_settings" or perhaps "dont_configure_monitors", but I really would like to avoid the latter; we should not have gconf keys with a negation in the name, then we should rather call it "configure_monitors".

With Federico's IRC statement I'll go with "use_xorg_monitor_settings" for now.
(Gosh, naming -- always the hardest part)
Comment 2 Martin Pitt 2010-10-05 09:41:07 UTC
Created attachment 171747 [details] [review]
RANDR - Add gconf key for disabling boot time configuration

This patch implements the proposal. It does not change the default behaviour, but when setting the gconf key to true, it does not touch the xrandr configuration any more (e. g. in gdm), but it still applies my custom monitors.xml in my own session.
Comment 3 Bastien Nocera 2010-10-05 09:42:58 UTC
This needs to use GSettings instead, and should block on the GSettings port.
Comment 4 Martin Pitt 2010-10-05 09:52:34 UTC
Hmkay -- git master still uses gconf, though. I don't see a gsettings branch?
Comment 5 Bastien Nocera 2010-10-05 10:08:22 UTC
(In reply to comment #4)
> Hmkay -- git master still uses gconf, though. I don't see a gsettings branch?

Work is on-going.
Comment 6 Rodrigo Moya 2010-11-05 09:42:33 UTC
Review of attachment 171747 [details] [review]:

I ported this to Gsettings and pushed it to master as:


commit 2ef2dfe21d6b8a6befc622a7991cf1e64e67c847
Author: Rodrigo Moya <rodrigo@gnome-db.org>
Date:   Fri Nov 5 10:38:40 2010 +0100

    Add settings key for disabling boot time configuration
    
    In a lot of situations it is undesirable to have g-s-d change the XRandR
    settings, because it overrides X.org customizations, leads to unnecessary mo
    switches, or increases boot time. Add a key "use-xorg-monitor-settings" to
    disable apply_default_boot_configuration(), in which case the XRandR
    configuration will not be touched unless there is a global or per-user
    configuration file.
    
    Ported initial patch from Martin Pitt to GSettings
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=631388
Comment 7 Bastien Nocera 2010-11-05 16:03:10 UTC
Pushed in gnome-2-32 as well, with a change to default the configuration to TRUE, so that Xorg's behaviour isn't changed.