After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 631372 - Preferences page gives no indication that password change was successful
Preferences page gives no indication that password change was successful
Status: RESOLVED FIXED
Product: snowy
Classification: Deprecated
Component: general
git master
Other Mac OS
: Normal normal
: 1.0 (public beta)
Assigned To: snowy-maint
snowy-maint
Depends on:
Blocks:
 
 
Reported: 2010-10-05 03:15 UTC by Sandy Armstrong
Modified: 2010-12-19 23:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
display "password changed" message (1.51 KB, patch)
2010-12-15 16:24 UTC, Natan Yellin 		accepted-commit_now Details | Review
clear password form (24.40 KB, patch)
2010-12-15 16:25 UTC, Natan Yellin 		none Details | Review
clear password form (24.40 KB, patch)
2010-12-15 16:40 UTC, Natan Yellin 		none Details | Review
clear password form (922 bytes, patch)
2010-12-19 16:50 UTC, Natan Yellin 		none Details | Review

Description Sandy Armstrong 2010-10-05 03:15:02 UTC 
1. Go to Preferences
2. Fill out Change Password form
3. Click Save

Expected results:

Change Password form fields clear, and a "password changed successfully" message appears.

Actual results:

Change Password form fields remain filled with the same data, and no message appears, misleading the user into thinking nothing happened.  Clicking Save again at this point will show an error message about having the wrong Old Password, because the password really *was* changed.
Comment 1 Natan Yellin 2010-12-15 16:24:55 UTC 
Created attachment 176476 [details] [review]
display "password changed" message
Comment 2 Natan Yellin 2010-12-15 16:25:22 UTC 
Created attachment 176477 [details] [review]
clear password form
Comment 3 Natan Yellin 2010-12-15 16:40:47 UTC 
Created attachment 176480 [details] [review]
clear password form

This is the same patch as before. I just added extra information to the commit message.
Comment 4 Brad Taylor 2010-12-17 15:30:11 UTC 
Hey Natan, thanks for the patch!

I'm kind of against bringing in a pretty sizeable library dependency for only one use, when the same action could be completed very simply without it.  Would you mind rewriting your code to avoid the dependency on jQuery.Form?  Thanks!
Comment 5 Jeff Schroeder 2010-12-17 15:54:59 UTC 
Natan: Something along the lines of this should work using only jquery.

$('.input-form input[type="password"]').val("")
Comment 6 Sandy Armstrong 2010-12-19 16:02:45 UTC 
Review of attachment 176476 [details] [review]:

This one looks good to me. Same comment as Brad on the other one.
Comment 7 Natan Yellin 2010-12-19 16:50:12 UTC 
Created attachment 176712 [details] [review]
clear password form
Comment 8 Natan Yellin 2010-12-19 16:51:27 UTC 
Thanks, Jeff. The above patch uses jquery directly, and it works exactly as you recommended.
Comment 9 Jeff Schroeder 2010-12-19 23:56:33 UTC 
Nice work Natan. Your changes have been pushed:
http://git.gnome.org/browse/snowy/log/