After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 631369 - Use autoreconf instead gnome-autogen.sh
Use autoreconf instead gnome-autogen.sh
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: general
3.2.x
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2010-10-05 01:54 UTC by Javier Jardón (IRC: jjardon)
Modified: 2012-08-08 17:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use autoreconf instead gnome-autogen.sh (1.47 KB, patch)
2010-10-05 01:55 UTC, Javier Jardón (IRC: jjardon) 		reviewed Details | Review

Description Javier Jardón (IRC: jjardon) 2010-10-05 01:54:11 UTC 
We can drop gnome-autogen.sh completely and use autoreconf instead
Comment 1 Javier Jardón (IRC: jjardon) 2010-10-05 01:55:14 UTC 
Created attachment 171730 [details] [review]
Use autoreconf instead gnome-autogen.sh
Comment 2 Steve Frécinaux 2010-10-05 07:27:13 UTC 
What's the point?
Comment 3 Ignacio Casal Quinteiro (nacho) 2010-10-05 09:22:31 UTC 
For me I guess it would be better having one less dep in windows. Though I really don't care that much.
Comment 4 Javier Jardón (IRC: jjardon) 2010-11-18 06:26:54 UTC 
As Ignacio said, one less dependency.

autoreconf is the "upstream" tool and can replace gnome-common completely.
Also gnome-common is a bit unmaintained and there are plans to deprecate it.
Comment 5 Ignacio Casal Quinteiro (nacho) 2010-11-18 16:48:00 UTC 
Review of attachment 171730 [details] [review]:

See inline comment.

::: autogen.sh
@@ +8,3 @@
+  gnome-doc-prepare --automake --copy --force &&
+  gtkdocize &&
+  autopoint --force &&

I saw that you removed this line in some modules, is this ok here or do you need to remove it also?
Comment 6 Javier Jardón (IRC: jjardon) 2010-11-18 16:56:16 UTC 
No, It's needed because intltoolize do not generate all the needed files.
Then we need to override the AUTOPOINT variable to call intltoolize, because we use intltool in the package.
Comment 7 Ignacio Casal Quinteiro (nacho) 2011-05-26 12:51:45 UTC 
if you feel like it, feel free to make the change in master
Comment 8 Ignacio Casal Quinteiro (nacho) 2012-03-09 21:09:40 UTC 
What about this?
Comment 9 André Klapper 2012-07-30 17:24:02 UTC 
Javier: ping?
Comment 10 Javier Jardón (IRC: jjardon) 2012-08-08 17:51:25 UTC 
commited in f386419501825eb0230790e692778c372632d8bd