After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 631335 - Spell check does not work with enabled fixed width or underline
Spell check does not work with enabled fixed width or underline
Status: RESOLVED FIXED
Product: gnote
Classification: Applications
Component: main
0.7.x
Other Linux
: Normal normal
: ---
Assigned To: gnote-maint
gnote-maint
Depends on:
Blocks:
 
 
Reported: 2010-10-04 17:39 UTC by Tim Sammut
Modified: 2010-10-09 11:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screen Shot with and without working spell check. (49.03 KB, image/png)
2010-10-04 17:39 UTC, Tim Sammut
  Details
Make spell check work with underline. (867 bytes, patch)
2010-10-08 19:22 UTC, Aurimas Černius
accepted-commit_now Details | Review

Description Tim Sammut 2010-10-04 17:39:49 UTC
Created attachment 171710 [details]
Screen Shot with and without working spell check.

Changing the text style in a note (to "fixed width" for example) removes all the red underlining that indicates misspelled words.
Comment 1 Aurimas Černius 2010-10-04 19:03:31 UTC
Thanks for bug report.
Underline does not work too. Also, checkboxes for both these items are not checked when selected text is unerlined/fixed width. Everything work fine with other formatting items.
Comment 2 Aurimas Černius 2010-10-08 19:22:11 UTC
Created attachment 171966 [details] [review]
Make spell check work with underline.

Since spell check underlines misspelled text with red curly line, ordinary underline does not work for misspelled text.
I'm not sure which one is more important. Currently spell check does not work at all for underlined text. With this patch applied, underline does not work for misspelled text.
Comment 3 Aurimas Černius 2010-10-08 19:24:08 UTC
I have fixed spell check for fixed width and checkboxes for both fixed width and underline in git. The decision for underline is needed.
To me, spell check didn't work only for underline and fixed width. The rest from formatting worked well.
Comment 4 Tim Sammut 2010-10-08 19:29:13 UTC
Thank you!

FWIW, I would personally prefer spelling checking to override underlining.
Comment 5 Hubert Figuiere (:hub) 2010-10-09 02:41:21 UTC
Comment on attachment 171966 [details] [review]
Make spell check work with underline.

Looks good to me. Please commit
Comment 6 Hubert Figuiere (:hub) 2010-10-09 02:43:00 UTC
BTW I think it was just a bug, I don't see why underline shouldn't spell checked.
Comment 7 Aurimas Černius 2010-10-09 11:17:07 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.