GNOME Bugzilla – Bug 631266
build against gtk3
Last modified: 2011-01-24 18:06:50 UTC
Created attachment 171650 [details] [review] patch here is a patch that bumps the gtk dependency to 2.90 (and also bumps several other libraries to their gtk3-using versions), and adapts the code to work with gtk3. It overlaps with https://bugzilla.gnome.org/show_bug.cgi?id=602040 insofar as it replaces the GduSpinner with GtkSpinner.
Note that I forgot to remove some gdu-spinner.h includes
so how can this get a review? davidz?
Created attachment 176264 [details] [review] Build against GTK+ 3 I updated Matthias' patch. I did the following extra: - 1 line tweak so configure.ac applies to git master - remove size_request and refactored as per gtk 3.0 migration guide - replaced deprecated gtk_widget_hide_all with gtk_widget_hide
*** Bug 636952 has been marked as a duplicate of this bug. ***
I applied this patch but it needed quite a bit of work http://git.gnome.org/browse/gnome-disk-utility/commit/?id=a58f325cbead303bf79026935927d83cb55c2f15 I'm not entirely sure how to deal with theming so right now the grid colors etc. are hard coded. Hoping to change that soon.
(In reply to comment #5) > I'm not entirely sure how to deal with theming so right now the grid colors > etc. are hard coded. Hoping to change that soon. Is there a bug report (ID?) to follow?
(In reply to comment #6) > (In reply to comment #5) > > I'm not entirely sure how to deal with theming so right now the grid colors > > etc. are hard coded. Hoping to change that soon. > > Is there a bug report (ID?) to follow? I've filed bug 640444 for now. FWIW, I started working on this today but quickly ran into problems. For starters, there's not a lot of gtk3 themes available to test with and/or other apps ported to gtk3 to learn from. And since GNOME3 will not ship with any UI to switch themes (AFAIK, anyway) it's probably fine to hard code the colors for now.
We still hope to ship hicontrast/lowcontrast/inverse themes, so hardcoding is not great
(In reply to comment #8) > We still hope to ship hicontrast/lowcontrast/inverse themes, so hardcoding is > not great That's why there's an open bug about it...