GNOME Bugzilla – Bug 631101
Enforce a format for birthday
Last modified: 2011-08-29 10:12:43 UTC
Woo. Empathy 2.32 has support for vcards. I can tell my birthday to the world! Except that I have no idea which format I should use for the date. Is it free text? Is it YYYY-MM-DD? Help! :-)
Yeah we should probably use the calendar widget or something.
Fixed in repo: git://vminko.org/empathy branch: fix-631101
Created attachment 173707 [details] [review] proposed fix
Thanks for the patch. Actually I was planning to work on this after my fix for bug #630421 has been merged as it's likely to conflict. Sorry, I should have made that clearer in the bug. :\ Anyway, would you mind rebasing your branch on top of mine? If not, I'll try to manually re-apply your changes once my branch has been merged.
No problem. The patches almost don't intersect. Here's the updated version: fix-631101-v2
I tried the branch but didn't manage to select any date in the calendar. Also, I don't like adding this special case in contact_widget_details_update_edit(). My plan was to add a function pointer to info_field_datas and use it to create the widget. Would be much cleaner IMHO.
>I tried the branch but didn't manage to select any date in the calendar. Do you mean that double clicking does not work? >Also, I don't like adding this special case in ... Fixed in the same branch.
(In reply to comment #7) > >I tried the branch but didn't manage to select any date in the calendar. > > Do you mean that double clicking does not work? Even simple clicking. I can change the month and year but not the day.
>I can change the month and year but not the day. Can this be a GTK issue? It works fine with GTK2. Can you select days in the log viewer?
Yeah it works fine in the log viewer.
I filed a GTK issue for this problem: https://bugzilla.gnome.org/show_bug.cgi?id=634657 So we've blocked with this enhancement till this issue is fixed.
For the record, I rebased this branch on top of master: http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/birthday-631101
It worked fine now so I merged the branch; thanks! This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.