After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 631098 - Always show status icon in contact right-click menu (for meta-contacts)
Always show status icon in contact right-click menu (for meta-contacts)
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2010-10-01 14:15 UTC by Vincent Untz
Modified: 2011-08-29 10:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Always show icons for meta-contacts in context menu (1.11 KB, patch)
2010-10-03 19:30 UTC, Vincent Untz
none Details | Review
http://git.Collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/presence-icon-631098 (1.10 KB, patch)
2010-10-04 07:56 UTC, Guillaume Desmottes
none Details | Review

Description Vincent Untz 2010-10-01 14:15:38 UTC
When I right-click on a meta-contact, I can see all the contacts that it's made of. Cool.

However, there's no way to see which one of those real contacts are online or not. And then I saw http://blog.desmottes.be/post/2010/10/01/Whats-new-in-Empathy-2320 ! There is actually icons there. Except that GNOME, by default, disables icons in menu. But it's a case where we do want the icons, imho.

gtk_image_menu_item_set_always_show_image() is your friend.
Comment 1 Vincent Untz 2010-10-03 19:30:19 UTC
Created attachment 171641 [details] [review]
Always show icons for meta-contacts in context menu
Comment 2 Guillaume Desmottes 2010-10-04 07:56:31 UTC
Created attachment 171672 [details] [review]
http://git.Collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/presence-icon-631098

 libempathy-gtk/empathy-contact-menu.c    |    1 -
 libempathy-gtk/empathy-individual-menu.c |    2 ++
 2 files changed, 2 insertions(+), 1 deletions(-)
Comment 3 Guillaume Desmottes 2010-10-04 09:22:51 UTC
Merged to 2.32 and master. Thanks for your patch!

This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.