After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 631051 - Port to latest GTK3
Port to latest GTK3
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-09-30 23:51 UTC by William Jon McCann
Modified: 2011-01-18 22:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Wait until the toplevel is realized before using it (2.37 KB, patch)
2010-09-30 23:52 UTC, William Jon McCann 		accepted-commit_now Details | Review
Update for new GTK3 drawing APIs (23.05 KB, patch)
2010-09-30 23:52 UTC, William Jon McCann 		committed Details | Review

Description William Jon McCann 2010-09-30 23:51:22 UTC 
Here is a set of patches to build the control center with the latest GTK3.  I have not ported the font-viewer because we should just remove it instead.  I have a separate patch to do that.
Comment 1 William Jon McCann 2010-09-30 23:52:31 UTC 
Created attachment 171458 [details] [review]
Wait until the toplevel is realized before using it
Comment 2 William Jon McCann 2010-09-30 23:52:33 UTC 
Created attachment 171459 [details] [review]
Update for new GTK3 drawing APIs
Comment 3 Rodrigo Moya 2010-10-01 09:29:56 UTC 
Review of attachment 171458 [details] [review]:

Looks ok to me
Comment 4 Rodrigo Moya 2010-10-01 09:40:05 UTC 
Review of attachment 171459 [details] [review]:

You have replaced gdk_cairo_create with cairo_create, but in drw-utils.c:

* cr = gdk_cairo_create (gtk_widget_get_window (window));

shouldn't this be cairo_create also?

ditto on scrollarea.c, it's replaced in one place and not replaced in another
Comment 5 Matthias Clasen 2010-10-01 16:33:02 UTC 
Review of attachment 171459 [details] [review]:

Rodrigo, you need gdk_cairo_create to create a cairo_t for a GdkWindow, but cairo_create to create a cairo_t for a cairo surface. Different things.
Comment 6 Rodrigo Moya 2010-10-04 08:02:23 UTC 
Ah, ok then, sorry
Comment 7 Rodrigo Moya 2010-10-04 08:03:23 UTC 
Review of attachment 171459 [details] [review]:

Looks good then
Comment 8 Bastien Nocera 2010-10-06 11:12:08 UTC 
Comment on attachment 171458 [details] [review]
Wait until the toplevel is realized before using it

Is this actually required?
Comment 9 André Klapper 2010-12-30 00:24:18 UTC 
(In reply to comment #8)
> (From update of attachment 171458 [details] [review])
> Is this actually required?

Jon: ping
Comment 10 William Jon McCann 2011-01-18 22:15:40 UTC 
I think we are done here.