After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 631004 - gnome-shell.in: Never add empty elements to LD_LIBRARY_PATH
gnome-shell.in: Never add empty elements to LD_LIBRARY_PATH
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 631003 637378 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-09-30 13:25 UTC by Vincent Untz
Modified: 2010-12-16 12:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gnome-shell.in: Never add empty elements to LD_LIBRARY_PATH (1.20 KB, patch)
2010-09-30 13:25 UTC, Vincent Untz 		committed Details | Review

Description Vincent Untz 2010-09-30 13:25:22 UTC 
This is not secure since empty elements mean current directory.
Comment 1 Vincent Untz 2010-09-30 13:25:25 UTC 
Created attachment 171423 [details] [review]
gnome-shell.in: Never add empty elements to LD_LIBRARY_PATH

An empty element means the current directory, and is insecure.
Comment 2 Vincent Untz 2010-09-30 13:26:05 UTC 
*** Bug 631003 has been marked as a duplicate of this bug. ***
Comment 3 Owen Taylor 2010-09-30 14:26:10 UTC 
Review of attachment 171423 [details] [review]:

Looks good (logic isn't quite complicated enough to extract into a function, even though we have it in two places)
Comment 4 Vincent Untz 2010-09-30 14:32:41 UTC 
Thanks.
Comment 5 Dan Winship 2010-12-16 12:30:57 UTC 
*** Bug 637378 has been marked as a duplicate of this bug. ***