GNOME Bugzilla – Bug 630943
Bigger default size for dialogs such as "Custom status"
Last modified: 2011-06-29 09:29:35 UTC
- Scrolling sucks. - The dialog used to edit the custom statuses is about 430x240 pixels in size. - Nobody has a resolution <1024x600 on the desktop. Therefore: the default size should probably be bigger than that :) Another dialog that might benefit from this is the favorite chatrooms editor.
I was working on fixing some of my rant on bug 640846 and made the dialog a bit bigger and better: <http://cgit.collabora.com/git/user/wjt/empathy.git/log/?h=status-dialog> Before: http://people.collabora.com/~wjt/tmp/old-status-editor.png After: http://people.collabora.com/~wjt/tmp/new-status-editor.png The scroll-y area is now in the golden ratio. (Previously the dialog as a whole was in the golden ratio.) I made it non-resizable, too: resizable sheets are kind of funky. Also I made it behave better and made the Add button less massive.
Created attachment 189672 [details] [review] PresenceChooser: remove unused #define FLASH_TIMEOUT
Created attachment 189673 [details] [review] PresetDialog test: quit cleanly Previously one had to kill the process, but by just switching to gtk_dialog_run() we get more functionality for less code. :D
Created attachment 189674 [details] [review] PresetDialog: make the window taller The element we really care about the size of is the list of statuses past. So I moved the horizontal size request to that—the window has 6px of padding or so, so this makes it pretty much exactly the same width—and made the height request be in the golden ratio to it. I'm probably unusual in having enough statuses to fill my laptop screen vertically, but, subjectively, this makes the dialog look less stubby even now I've removed them all to test.
Created attachment 189675 [details] [review] PresetDialog: make Add button less huge. I tried and failed to make it the same size as the other two buttons, so this will have to do.
Created attachment 189676 [details] [review] PresetDialog: Don't allow resizing status preset dialog It's big enough.
Created attachment 189677 [details] [review] PresetDialog: Allow >1 status to be removed at a time. This is pretty niche but we may as well. I want it sometimes. There's no reason to disallow it, and it's not like it adds any significant complexity.
Created attachment 189678 [details] [review] PresetDialog: Select text cell of freshly-added status This means you can just mash Enter to edit your mistake. It's more useful than leaving the text entry focused. It also helps hide a bug where the entry doesn't get cleared if you just start typing another message. So previously, typing: Hello<Enter>Miaow<Enter> would give you two statuses, "Hello" and "MiaowEnter Custom Message". It didn't seem worth fixing this much more since Gtk+ 3.2 will probably grow native support for placeholder text: <https://bugzilla.gnome.org/show_bug.cgi?id=440963>
Created attachment 189679 [details] [review] PresetDialog: Don't leak path when focusing freshly-created status (This was not introduced by my changes.)
Review of attachment 189672 [details] [review]: ++
Review of attachment 189673 [details] [review]: ++
Review of attachment 189674 [details] [review]: ++
Review of attachment 189675 [details] [review]: ++
Review of attachment 189676 [details] [review]: ++
Review of attachment 189677 [details] [review]: ++
Review of attachment 189678 [details] [review]: ++
Review of attachment 189679 [details] [review]: ++ You can push it to gnome-3.0 as well if you're keen.
(In reply to comment #17) > You can push it to gnome-3.0 as well if you're keen. I merged an equivalent patch to gnome-3-0.
Created attachment 190571 [details] [review] PresetDialog: GNOME 3-ify the remove button Yum yum joined-toolbar!
Created attachment 190572 [details] [review] PresetDialog: make status icon in entry non-activatable It's not meaningfully activatable; this has the effect of making it not glow on mouse-over, and preventing the cursor from changing from a caret back to a pointer.
Created attachment 190573 [details] [review] PresetDialog: remove support for adding statuses entirely We already have a way to do this, namely on the contact list itself. So this dialog now becomes just a way to edit/remove the existing statuses. The margins on the VBox are chosen to make its right-hand edge line up exactly with the right-hand edge of the Close button in the dialog.
So here are three more patches. The first two are uncontroversial, and make the dialog look like this: http://willthompson.co.uk/misc/saved-statuses-during.png For reference, it used to look like this: http://willthompson.co.uk/misc/saved-statuses-before.png The last one is a little more controversial and makes it look like this: http://willthompson.co.uk/misc/saved-statuses-after.png If we wanted to support adding and/or activating statuses from this dialog, it could look like this: http://willthompson.co.uk/misc/saved-statuses-hypothetical.png
I don't like the last one, it has too many weird icons which mean things which aren't clear. Perhaps this is just what a toolbar is though? *shrug*
(In reply to comment #23) > I don't like the last one, it has too many weird icons which mean things which > aren't clear. Perhaps this is just what a toolbar is though? *shrug* I don't really like it either; it was just a possible alternative to adding an “Activate selected status” button at the bottom.
Review of attachment 190571 [details] [review]: ++
Review of attachment 190572 [details] [review]: ++
Review of attachment 190573 [details] [review]: Let's keep it simple, ++
Merged: http://git.gnome.org/browse/empathy/commit/?id=3e22c794dd4568a69c08ce80cc12e03eb27f836c And here come a couple more patches to make the Manage Favourite Rooms dialog a little bigger by default (making the scrolled window exactly the same size, in fact) and conjoin the toolbar while we're there: http://willthompson.co.uk/misc/manage-favourite-rooms.png
Created attachment 190588 [details] [review] ChatroomsWindow: GNOME 3-ify the Remove button
Created attachment 190589 [details] [review] ChatroomsWindow: make the minimum size a bit bigger This patch makes the scrolled window's minimum size request the same as the new size for the status editor's scrolled window.
Review of attachment 190588 [details] [review]: ++
Review of attachment 190589 [details] [review]: ++
I merged them all! <http://git.gnome.org/browse/empathy/log/?id=9d13e5abfc9802832cc0e81cfa96663ffdd4744d> This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.