After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630942 - Don't time out urgent notifications
Don't time out urgent notifications
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
unspecified
Other Linux
: High normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-09-29 19:49 UTC by Marina Zhurakhinskaya
Modified: 2011-01-11 22:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
This is a very simple patch by checking for Urgency.CRITICAL in this._notification.urgency, and it makes the this._notificationTimeout returns true unless it's not of the former urgency. (1009 bytes, patch)
2011-01-06 12:52 UTC, Hellyna Ng 		none Details | Review
Notifications with CRITICAL urgency are no longer timed out (1.69 KB, patch)
2011-01-11 21:35 UTC, Hellyna Ng 		committed Details | Review

Description Marina Zhurakhinskaya 2010-09-29 19:49:16 UTC 
Use 'expires' or some other hint to make urgent notifications stay on the
screen until the user acknowledges them (i.e. by selecting an action, clicking
on the notification, hitting Esc or down arrow).
Comment 1 Hellyna Ng 2010-12-30 21:22:13 UTC 
Wanted to work on this actually but guess it would be better if we have Bug 630934 fixed first, since we have new urgency mappings in that patch.
Comment 2 Hellyna Ng 2011-01-06 12:52:39 UTC 
Created attachment 177649 [details] [review]
This is a very simple patch by checking for Urgency.CRITICAL in this._notification.urgency, and it makes the this._notificationTimeout returns true unless it's not of the former urgency.

The glib documentation specify that it will call the function repeatedly until it returns false, so maybe there are more graceful patches than this. Maybe we should increase the time out so the function call intervals are shorter? Since it will last indefinitely until the user do something.
Comment 3 Hellyna Ng 2011-01-06 12:55:43 UTC 
EDIT: s/function\ call\ intervals\ are\ shorter/function\ call\ intervals\ are\ longer/g
Comment 4 Hellyna Ng 2011-01-11 21:35:10 UTC 
Created attachment 178089 [details] [review]
Notifications with CRITICAL urgency are no longer timed out

Notifications with CRITICAL urgency should not pop down until the user interacts with them.
Comment 5 Hellyna Ng 2011-01-11 21:43:59 UTC 
committed