After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630939 - Don't automatically show the summary when an icon gets removed from it
Don't automatically show the summary when an icon gets removed from it
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
unspecified
Other Linux
: High normal
: ---
Assigned To: Florian Müllner
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-09-29 19:46 UTC by Marina Zhurakhinskaya
Modified: 2010-10-05 20:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
messageTray: Do not show the summary when removing a source (1.16 KB, patch)
2010-09-29 20:58 UTC, Florian Müllner 		committed Details | Review
Don't show the summary if a new item got removed before we had a chance to show it (3.65 KB, patch)
2010-09-30 21:11 UTC, Marina Zhurakhinskaya 		committed Details | Review

Description Marina Zhurakhinskaya 2010-09-29 19:46:22 UTC 
Don't show the summary if its content changes while the message tray is not
in use (e.g. because the user focused on the window which caused the icon for
that window to be removed from the message tray).
Comment 1 Marina Zhurakhinskaya 2010-09-29 20:09:53 UTC 
We actually never want to show the summary automatically when an icon got removed from it. We only want to show summary automatically when an item got added to it because a) some notification was shown that resulted in a new icon landing in the summary b) a new tray icon was added.
Comment 2 Florian Müllner 2010-09-29 20:58:53 UTC 
Created attachment 171360 [details] [review]
messageTray: Do not show the summary when removing a source

Having the summary pop up automatically after a source icon has been
removed is pretty useless ("Hey, there was something interesting going
on, but you missed it and it's gone now, kthxbye").
Comment 3 Florian Müllner 2010-09-29 21:11:59 UTC 
Attachment 171360 [details] pushed as 109de6a - messageTray: Do not show the summary when removing a source
Comment 4 Marina Zhurakhinskaya 2010-09-30 21:11:28 UTC 
Created attachment 171454 [details] [review]
Don't show the summary if a new item got removed before we had a chance to show it

It's possible that an item that was added to the summary got removed before
we had a chance to show the summary because the user has interacted with
the notification (e.g. clicked on an application ready notification). We should
not be showing the summary with an unchanged set of items in this case.

However, it is possible that multiple items were added to the summary before
we had a chance to show the summary, and only some of them got removed. In view
of this scenario, we can't just use a boolean flag to indicate if the summary
needs to be shown, but have to maintain an array of new summary items instead.
Comment 5 Florian Müllner 2010-10-05 16:47:22 UTC 
Review of attachment 171454 [details] [review]:

Works as expected and looks reasonable - I had been wondering whether adding a flag to summary items (hasBeenShown) and using an integer count for newSummaryItems would have been nicer, but probably not ...