After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630877 - Windows are black in gnome-mag
Windows are black in gnome-mag
Status: RESOLVED FIXED
Product: gnome-mag
Classification: Deprecated
Component: magnifier-utility
0.16.x
Other Linux
: Normal critical
: ---
Assigned To: gnome-mag-maint
gnome-mag-maint
Depends on:
Blocks:
 
 
Reported: 2010-09-29 08:44 UTC by Li Yuan
Modified: 2010-10-30 14:50 UTC
See Also:
GNOME target: ---
GNOME version: 2.29/2.30

Attachments
screenshot (426.69 KB, image/png)
2010-09-29 08:44 UTC, Li Yuan 		  Details
Patch (854 bytes, patch)
2010-10-09 08:02 UTC, Li Yuan 		none Details | Review

Description Li Yuan 2010-09-29 08:44:47 UTC 
Created attachment 171326 [details]
screenshot

Start Orca, and enable magnifier in full screen. Some windows are black and totally inaccessible.
Comment 1 Fernando Herrera 2010-09-30 07:40:53 UTC 
Could you run from a terminal:

/usr/bin/magnifier -v -m

and check if it works? Which version of the magnifier is it?
Comment 2 Li Yuan 2010-10-08 03:52:12 UTC 
With "/usr/bin/magnifier -v -m", it can not show menus right, no right click menus, windows are cut. As you can see in https://defect.opensolaris.org/bz/show_bug.cgi?id=17162.
Comment 3 Li Yuan 2010-10-08 08:17:43 UTC 
Hi Fernando, can you point me the code which is responsible for magnification of a single window?
Comment 4 Li Yuan 2010-10-09 08:02:03 UTC 
Created attachment 171995 [details] [review]
Patch

The patch to fix the bug.
Comment 5 Fernando Herrera 2010-10-09 21:21:39 UTC 
Review of attachment 171995 [details] [review]:

The patch fixes the issue, however, aren't we clipping too much extra area setting coords to 0,0?

Why pgmag_win->attr.x and pgmag_win->attr.y values are not correct?
Comment 6 Li Yuan 2010-10-11 07:09:44 UTC 
I think it is because final_clip hasn't been translated since it is created. Translate the final_clip by pgmag_win->attr.x and pgmag_win->attr.y can also fix the problem.
Comment 7 Fernando Herrera 2010-10-30 14:50:42 UTC 
Ok, I have applied the patch to master and released 0.16.3

Thanks for this!