After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630863 - Crash when rotating an image with a non-file URI
Crash when rotating an image with a non-file URI
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: Editing
0.8.0
Other Linux
: Normal normal
: 0.8.1
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2010-09-28 23:21 UTC by Nuno Ferreira
Modified: 2010-10-23 22:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch using Gio instead of System.IO (1.33 KB, patch)
2010-09-28 23:21 UTC, Nuno Ferreira 		committed Details | Review

Description Nuno Ferreira 2010-09-28 23:21:18 UTC 
Created attachment 171311 [details] [review]
patch using Gio instead of System.IO

Code is assuming the image is local and using System.IO API, patch attached that uses GIO instead
Comment 1 Ruben Vermeersch 2010-10-21 10:56:36 UTC 
Review of attachment 171311 [details] [review]:

Patch looks good. Please format patches with git format-patch in the future though.

There's another occurrence of this problem in the tree, could you patch that one up as well?

[j bgo-630863|AM] kyushu:f-spot $ git grep FileAttributes.ReadOnly
src/Extensions/Tools/FSpot.Tools.MergeDb/FSpot.Tools.MergeDb/MergeDb.cs:                                        File.SetAttributes (destination, File.GetAttributes (destination) & ~FileAttributes.ReadOnly);

Will merge. Thanks a lot!
Comment 2 Ruben Vermeersch 2010-10-21 11:03:37 UTC 
I re-added the "done = true;" statement which got left out though.
Comment 3 Nuno Ferreira 2010-10-23 22:31:43 UTC 
(In reply to comment #1)
> There's another occurrence of this problem in the tree, could you patch that
> one up as well?
> 
> [j bgo-630863|AM] kyushu:f-spot $ git grep FileAttributes.ReadOnly
> src/Extensions/Tools/FSpot.Tools.MergeDb/FSpot.Tools.MergeDb/MergeDb.cs:       
>                                 File.SetAttributes (destination,
> File.GetAttributes (destination) & ~FileAttributes.ReadOnly);
> 

Sorry but I can't do it right now, that code needs a lot more work to work with Gio, I'm not really familiar with Gio's APIs and I gave up using f-spot until I have some time to make some more tests because of #630860