After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630853 - Remove -Wfloat-equal
Remove -Wfloat-equal
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
: 630852 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-09-28 21:21 UTC by Owen Taylor
Modified: 2010-09-30 14:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove -Wfloat-equal (1.04 KB, patch)
2010-09-28 21:22 UTC, Owen Taylor 		accepted-commit_now Details | Review

Description Owen Taylor 2010-09-28 21:21:59 UTC 
While -Wfloat-equal warns on dubious constructs, it also warns on
valid constructs, and there is no way to suppress the warning.

In particular, it's currently warning for every single file because of
JS_CANONICALIZE_NAN() in the xulrunner headers.
Comment 1 Owen Taylor 2010-09-28 21:22:01 UTC 
Created attachment 171302 [details] [review]
Remove -Wfloat-equal
Comment 2 Havoc Pennington 2010-09-28 21:50:04 UTC 
Review of attachment 171302 [details] [review]:

yep
Comment 3 Colin Walters 2010-09-30 14:34:25 UTC 
*** Bug 630852 has been marked as a duplicate of this bug. ***
Comment 4 Owen Taylor 2010-09-30 14:50:13 UTC 
Pushed