GNOME Bugzilla – Bug 630726
Replicate checkoutdir directory trees below buildroot
Last modified: 2010-11-19 07:37:47 UTC
When using an external buildroot, use the same directory layout as for checkoutroot. This will prevent clashes when repositories have the same basename. Signed-off-by: Dirk Wallenstein <halsmit@t-online.de>
Created attachment 171199 [details] [review] Replicate checkoutdir directory trees below buildroot
Review of attachment 171199 [details] [review]: Ah! Will create a patch for all modtypes, soon.
Created attachment 171214 [details] [review] Replicate checkoutdir directory trees below buildroot When using an external buildroot, use the same directory layout as for checkoutroot. This will prevent clashes when repositories have the same basename. Add this behavior to all modtypes that already support an external build directory.
Review of attachment 171214 [details] [review]: I don't understand the documentation after your change. I think the documentation should be unchanged - after the patch, the directory name is still the directory name where the source lives. Just obtaining the directory name in a more correct manner.
Yes, that is a bit of a strange text. What I wanted to say is that the full checkoutdir will be used and not just the basename. That makes a difference in Xorg when when the main 'xorg/xorg-server' module gets overridden by another repo 'people/krh/xorg-server'.
Created attachment 174762 [details] [review] Replicate checkoutdir directory trees below buildroot When using an external buildroot, use the same directory layout as for checkoutroot. This will prevent clashes when repositories have the same basename. Add this behavior to all modtypes that already support an external build directory. Signed-off-by: Dirk Wallenstein <halsmit@t-online.de>
Comment on attachment 174762 [details] [review] Replicate checkoutdir directory trees below buildroot Thank you. Committed. http://git.gnome.org/browse/jhbuild/commit/?id=c5db5e1dcdc82557528ab76a90da90a84699fc75