Bug 630700 – Crash on message send

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 630700 - Crash on message send


Summary:	Crash on message send


Status:	RESOLVED FIXED

Product:	evolution
Classification:	Applications
Component:	Mailer
Version:	2.32.x (obsolete)
Hardware:	Other Linux

Importance:	Normal critical
Target Milestone:	---
Assigned To:	evolution-mail-maintainers
QA Contact:	Evolution QA team

URL:
Whiteboard:

Duplicates:	632814 (view as bug list)
Depends on:
Blocks:

Reported:	2010-09-27 07:44 UTC by Milan Crha
Modified:	2013-09-13 01:04 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
evo patch (546 bytes, patch) 2010-09-27 07:52 UTC, Milan Crha	committed	Details \| Review

Description Milan Crha 2010-09-27 07:44:47 UTC

Forwarding from a downstream bug report:
https://bugzilla.redhat.com/show_bug.cgi?id=629753

Evolution can crash when hitting Send/Receive and there are pending messages to be send, when the Sent folder configured on the account cannot be found due to some error.

The reason is that the function returns NULL, but doesn't return GError, which is dereferenced later.

+ Trace 223904

Thread 1 (Thread 4053)

#0 mail_send_message
at mail-ops.c line 607
#1 send_queue_exec
at mail-ops.c line 786
#2 mail_msg_proxy
at mail-mt.c line 469
#3 g_thread_pool_thread_proxy
at gthreadpool.c line 314
#4 g_thread_create_proxy
at gthread.c line 1897
#5 start_thread
at pthread_create.c line 301
#6 clone
at ../sysdeps/unix/sysv/linux/x86_64/clone.S line 115

Comment 1 Milan Crha 2010-09-27 07:52:59 UTC

Created attachment 171178 [details] [review]
evo patch

for evolution;

Test whether the local_error is set or not before dereferencing it.

Comment 2 Milan Crha 2010-09-29 09:13:55 UTC

Created commit 1214957 in evo master (2.33.1+)
Created commit 84f0a15 in evo gnome-2-32 (2.32.1+)

Comment 3 Akhil Laddha 2010-10-22 03:36:31 UTC

*** Bug 632814 has been marked as a duplicate of this bug. ***