GNOME Bugzilla – Bug 630681
drop GtkObject use
Last modified: 2014-06-08 14:32:42 UTC
Created attachment 171163 [details] [review]
GtkObject is gone in GTK3. See
Review of attachment 171163 [details] [review]:
(In reply to comment #0)
> Created an attachment (id=171163) [details] [review]
> GtkObject is gone in GTK3. See
Sorry for the delay in replying. I'll try to do better in future.
This doesn't compile for me. Is it dependent on something else? Specifically, GtkWidgetClass (unlike GtkObjectClass) has no member "destroy", yet code in src/ui/frames.c attempts to assign to it.
I have created a branch in git with this patch checked in:
Yeah, this patch misses the configure part where you need to build against gtk3...
[Removing GNOME3.0 target as decided in release-team meeting on March 03, 2011. "nice-to-have" categorisation for GNOME3.0]
Still existing in git master in
I vote for just committing, like for bug 572332.
Florian, can you put this in your queue ?
Do we actually still want this? As far as I can see, the patch requires a port from GTK+-2 to GTK+-3, which involves a lot more than some configure glue (mostly the GtkWidget::expose-event => GtkWidget::draw change). It's not particularly difficult to do given that the work has been done for Mutter already, but considering the recent mesa improvements, I do wonder if it's reasonable to spend much time on Metacity ...
you may be right. feel free to close it out, then