GNOME Bugzilla – Bug 630679
[PATCH] Updated clutter bindings to 1.6.9
Last modified: 2011-07-10 08:16:27 UTC
This is the first time I've ever done anything of this nature. But I hope it worked. I've attached a patch that updates the vapi for clutter-1.0.vapi to add features added in the recent stable release 1.4. Go easy on me, it's a learning experience, and I would love to contribute much more in the future.
Created attachment 171161 [details] [review] clutter-1.0.vapi to version 1.4
Created attachment 171164 [details] [review] updated clutter-1.0.deps to include atk
It looks like it include the key bindings from CLUTTER_... but I'm not sure if they should be put in a namespace or not??
Thank you for the patch. The issue I see as you pointed out is the key bindings. Could you please try editing the clutter-1.0.excludes and changing clutter-keysyms.h to clutter-keysyms-compat.h and then regenerating the bindings ?
Created attachment 171451 [details] [review] new excludes I had to edit the cogl custom cname to get the vapigen for clutter-1.0 to work. Everything is assigned a cname of CoglHandle??
Created attachment 183309 [details] [review] patch that updates cogl and clutter vapis to 1.6.9 bindings I did not use metadata (I tried but I couldn't get it to work). The GI is manually edited to generate the vapis :(
Created attachment 183310 [details] convenience tar for clutter 1.6.9 and cogl vapis This is the vapis I made tar'd up for easy usage.
I uploaded my current vapi's and patch of bindings version 1.6.9 here. Sadly enough, I had to manually edit a gi and the cogl vapi to get this to work. I use clutter with vala on a daily basis and if someone could help me with the metadata files to get the gi's to read properly I'd love to maintain these bindings.
commit d495141d2d11df0ad59471182b90f87b8d4f12e0 Author: Luca Bruno <lucabru@src.gnome.org> Date: Thu Jun 9 21:11:36 2011 +0200 clutter-1.0: Switch to GIR Fixes bugs 643773 and 630679. This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Thanks for the patches Jonathan. I see there's some work for keysyms as well and cogl somehow. Those need to be updated to the gir switch. I'm sorry I know it's not that nice, anyway I thought it was better to first switch to gir before doing any other big bindings update. Feel free to open new separate bugs for cogl and clutter keysyms. About keysyms, I think that names are too generic to be put into the Clutter namespace because if a program adds an "using Clutter;" that will indeed break some name resolution. I'd suggest to put all the constants into nested namespaces.