After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630652 - Expanding and adding GnuCash Other Assets
Expanding and adding GnuCash Other Assets
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: Documentation
git-master
Other Linux
: Normal normal
: ---
Assigned To: Chris Lyttle
Chris Lyttle
Depends on:
Blocks:
 
 
Reported: 2010-09-26 19:20 UTC by Tom Bullock
Modified: 2018-06-29 22:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Describes expansion of Other Assets Briefly (28.07 KB, application/xml)
2010-09-26 19:25 UTC, Tom Bullock
  Details
New Chapter 16 containing expanded types of assets (27.24 KB, application/xml)
2010-09-26 19:26 UTC, Tom Bullock
  Details
Contains the differences between trunk and the working copies (6.46 KB, application/octet-stream)
2010-09-26 19:29 UTC, Tom Bullock
  Details
changes to add chapter 16 to the Guide (8.28 KB, application/xml)
2010-09-26 19:31 UTC, Tom Bullock
  Details
adds Chapter 16 to the script that builds the Guide (1.04 KB, application/xml)
2010-09-26 19:33 UTC, Tom Bullock
  Details
Revised version of Tom Bullock's patch (33.14 KB, patch)
2010-09-27 04:03 UTC, Yawar Amin
accepted-commit_now Details | Review

Description Tom Bullock 2010-09-26 19:20:19 UTC
this fix modifies 3 files: gnucash-guide.xml, ch_accts.xml, & makefile.am.  The fix also adds a new file: ch_oth_assets.xml, which becomes Chapter 16 in the Tutorial & Concepts Guide.

Attached to bug report is a file showing differences between what is in documentation trunk and my working files.  This file is named diffs09262010

Also attached are my working files (named above) containing my changes.

I believe these are ready for developer review and corrections (if needed); if none is needed, then a developer should please post these to documentation trunk for the Guide.  

No changes have been made here to the Help documentation.
Comment 1 Tom Bullock 2010-09-26 19:22:56 UTC
I cannot tell if any files were added to this bug fix.  If not, please instruct me how this should be done.

Thanks.
Comment 2 Tom Bullock 2010-09-26 19:25:06 UTC
Created attachment 171142 [details]
Describes expansion of Other Assets Briefly

this is updated chapter 3 of the Guide.
Comment 3 Tom Bullock 2010-09-26 19:26:39 UTC
Created attachment 171143 [details]
New Chapter 16 containing expanded types of assets

this is the main point of the changes to the Guide.
Comment 4 Tom Bullock 2010-09-26 19:29:57 UTC
Created attachment 171144 [details]
Contains the differences between trunk and the working copies

this contains differences to gnucash-guide.xml, ch_accts.xml, and makefile.am all in /guide/C.  It also refences the new chapter16, which has the name ch_oth_assets.xml
Comment 5 Tom Bullock 2010-09-26 19:31:50 UTC
Created attachment 171145 [details]
changes to add chapter 16 to the Guide

changes to add Chapter 16 to the Guide
Comment 6 Tom Bullock 2010-09-26 19:33:16 UTC
Created attachment 171146 [details]
adds Chapter 16 to the script that builds the Guide 

adds Chapter 16 to the script that builds the Guide
Comment 7 Tom Bullock 2010-09-26 19:34:11 UTC
(In reply to comment #1)
> I cannot tell if any files were added to this bug fix.  If not, please instruct
> me how this should be done.
> 
> Thanks.

Files now attached.  Ignore above request.
Comment 8 Tom Bullock 2010-09-26 20:46:58 UTC
this fix applied against release 19612 for documentation download.
Comment 9 Yawar Amin 2010-09-27 04:03:34 UTC
Created attachment 171173 [details] [review]
Revised version of Tom Bullock's patch

Mostly cosmetic changes made, including:

* Consolidate changes to existing files + addition of new chapter file into single patch
* Replace straight quotes with curly quotes everywhere
* Get rid of extra whitespace (Space and Tab characters)
* Make several paragraphs in `Travel Advances' section gender-neutral, and tweak some sentences where necessary to avoid using too many `he or she' phrases
* Adjust indentation and text wrapping with Emacs' XML mode
* One or two sp corrections
* Get rid of note about asset account debits and credits effect on balance because it's effectively the same as note `More on Debits and Credits' at the end of section 3.2.2 (Income and Expense Accounts)
Comment 10 Yawar Amin 2010-10-09 20:14:19 UTC
Committed fix as series of patches: r19618--9 to introduce and format the new content, and r19628--9 to improve spelling, grammar and DocBook markup usage. Sorry for the late update here–I mistakenly thought committing to SVN with a ‘Fix #630652’ message would mark this bug as resolved. I have to learn more about BugZilla :-)

In the meantime, can someone mark this as resolved? Thanks!
Comment 11 Yawar Amin 2010-10-16 03:26:41 UTC
Changes backported to 2.2 branch in revisions 19660 to 19663.
Comment 12 Yawar Amin 2010-10-24 01:06:48 UTC
Comment on attachment 171173 [details] [review]
Revised version of Tom Bullock's patch

Mark patch as obsolete because fix applied as series of commits
Comment 13 John Ralls 2018-06-29 22:45:10 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=630652. Please update any external references or bookmarks.