GNOME Bugzilla – Bug 630508
Wrap g_get_system_{config,data}_dirs
Last modified: 2010-09-24 22:07:46 UTC
SSIA
Created attachment 171020 [details] [review] Optional tidy up patch
Created attachment 171021 [details] [review] Add the new functions
Comment on attachment 171021 [details] [review] Add the new functions Don't we already have a function for turning an array of strings into a python tuple? Otherwise it looks good.
(In reply to comment #3) > (From update of attachment 171021 [details] [review]) > Don't we already have a function for turning an array of strings into a python > tuple? Otherwise it looks good. strv_to_pylist lives in pygio, but using that would have been more invasive as pyglib doesn't link to pygio. These intra-static-library-python-module dependencies were really hard to solve to get this going on windows the first time. However, pygio already links with pyglib, and there is nothing gio specific about strv_to_pylist, so I suggest putting the function in a (new) pyglib-utils.{c,h} and gio using the functions in there. Would you like me to commit this as is, and implement the suggested approach later, or fix it up now?
Commit now, and fix up later. Common functionality like this should be accessible by all the modules so we don't duplicate and end up chasing the same bugs. Can you just add a FIXME:, thanks. btw keep in mind the gio stuff is going to be split out so any solution should be linkable from external libraries. Thanks.
Oh and can you commit the two patches as one commit? check out git rebase -i if you don't know how to rewrite local branches. if the two patches are at your head you can just git rebase -i HEAD^^ and read the instructions that pop up.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.