After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630508 - Wrap g_get_system_{config,data}_dirs
Wrap g_get_system_{config,data}_dirs
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2010-09-24 10:54 UTC by John Stowers
Modified: 2010-09-24 22:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Optional tidy up patch (1.41 KB, patch)
2010-09-24 10:55 UTC, John Stowers
none Details | Review
Add the new functions (1.67 KB, patch)
2010-09-24 10:56 UTC, John Stowers
accepted-commit_now Details | Review

Description John Stowers 2010-09-24 10:54:41 UTC
SSIA
Comment 1 John Stowers 2010-09-24 10:55:32 UTC
Created attachment 171020 [details] [review]
Optional tidy up patch
Comment 2 John Stowers 2010-09-24 10:56:01 UTC
Created attachment 171021 [details] [review]
Add the new functions
Comment 3 johnp 2010-09-24 16:10:29 UTC
Comment on attachment 171021 [details] [review]
Add the new functions

Don't we already have a function for turning an array of strings into a python tuple?  Otherwise it looks good.
Comment 4 John Stowers 2010-09-24 21:14:35 UTC
(In reply to comment #3)
> (From update of attachment 171021 [details] [review])
> Don't we already have a function for turning an array of strings into a python
> tuple?  Otherwise it looks good.

strv_to_pylist lives in pygio, but using that would have been more invasive as pyglib doesn't link to pygio. These intra-static-library-python-module dependencies were really hard to solve to get this going on windows the first time.

However, pygio already links with pyglib, and there is nothing gio specific about strv_to_pylist, so I suggest putting the function in a (new) pyglib-utils.{c,h} and gio using the functions in there.

Would you like me to commit this as is, and implement the suggested approach later, or fix it up now?
Comment 5 johnp 2010-09-24 21:52:13 UTC
Commit now, and fix up later.  Common functionality like this should be accessible by all the modules so we don't duplicate and end up chasing the same bugs.  Can you just add a FIXME:, thanks.  btw keep in mind the gio stuff is going to be split out so any solution should be linkable from external libraries.  Thanks.
Comment 6 johnp 2010-09-24 21:54:22 UTC
Oh and can you commit the two patches as one commit?  check out git rebase -i if you don't know how to rewrite local branches.  if the two patches are at your head you can just git rebase -i HEAD^^ and read the instructions that pop up.
Comment 7 John Stowers 2010-09-24 22:07:46 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.