After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630500 - [rtspsrc] does rtsp setup message always need "/UDP" string?
[rtspsrc] does rtsp setup message always need "/UDP" string?
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.26
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-09-24 09:26 UTC by Tibor Kocsis
Modified: 2010-09-24 14:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
RTSP messages (4.08 KB, text/plain)
2010-09-24 09:26 UTC, Tibor Kocsis
Details

Description Tibor Kocsis 2010-09-24 09:26:39 UTC
Created attachment 171009 [details]
RTSP messages

Hi,

I try to connect to a sanyo camera on rtp, but with gstreamer i get bad request. VLC can connect to camera, the RTSP messages are attached. The first different is in this line:

VLC: 

SETUP rtsp://10.30.0.119:554/VideoInput/1/h264/1/trackID=1 RTSP/1.0

CSeq: 4

Transport: RTP/AVP;unicast;client_port=54714-54715

from gstreamer (port setted with port-range):

SETUP rtsp://10.30.0.119:554/VideoInput/1/h264/1/trackID=1 RTSP/1.0

CSeq: 4

Transport: RTP/AVP/UDP;unicast;client_port=56366-56367

rtspsrc always appends the "/UDP" string, are you sure is it correct? Maybe the sanyo webcam has wrong rtsp implementation?

rtspsrc.c:
http://cgit.freedesktop.org/gstreamer/gst-plugins-good/tree/gst/rtsp/gstrtspsrc.c#n4591

Regards,
Tibor
Comment 1 Wim Taymans 2010-09-24 14:13:14 UTC
> 
> Transport: RTP/AVP/UDP;unicast;client_port=56366-56367
> 
> rtspsrc always appends the "/UDP" string, are you sure is it correct? Maybe the
> sanyo webcam has wrong rtsp implementation?

According to the RFC, RTP/AVP and RTP/AVP/UDP are the same, so yes it is correct and the webcam has a wrong rtsp implementation.

However, if it improves interoperability, we should remove the /UDP.
Comment 2 Levente Farkas 2010-09-24 14:18:38 UTC
imho rtspsrc should have to says what the server said. ie. if the camera/server says RTP/AVP then gstreamer should replay RTP/AVP and if the server send RTP/AVP/UDP gstreamer should replay RTP/AVP/UDP.
Comment 3 Wim Taymans 2010-09-24 14:24:44 UTC
(In reply to comment #2)
> imho rtspsrc should have to says what the server said. ie. if the camera/server
> says RTP/AVP then gstreamer should replay RTP/AVP and if the server send
> RTP/AVP/UDP gstreamer should replay RTP/AVP/UDP.

In this case, rtspsrc has to start the conversation.

It looks like the /UDP has always been there and it says in the comment that some servers need it. We should probably try to remove it to match vlc.
Comment 4 Wim Taymans 2010-09-24 14:29:08 UTC
commit ef29a59903cf37e01deb26808bd2b5eb91af3890
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Fri Sep 24 16:26:20 2010 +0200

    rtspsrc: don't add /UDP in the transport, it's the default
    
    don't add the default UDP lower-transport, some servers don't seem to like it.
    
    Fixes #630500