After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630493 - Using full resolution during searches will cause an uninitialised pointer access
Using full resolution during searches will cause an uninitialised pointer access
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: core
git master
Other Linux
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2010-09-24 08:22 UTC by Chris Lord
Modified: 2010-09-24 14:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix uninitialised pointer access in grl_metadata_source_setup_full_resolution_mode (1.26 KB, patch)
2010-09-24 08:22 UTC, Chris Lord 		none Details | Review

Description Chris Lord 2010-09-24 08:22:48 UTC 
Created attachment 171003 [details] [review]
Fix uninitialised pointer access in grl_metadata_source_setup_full_resolution_mode

If you do a metadata query with full resolution mode, grl_metadata_source_setup_full_resolution_mode will try to free uninitialised memory if the source already supports all the keys in the given key-list.

Attached patch fixes this.
Comment 1 Víctor Manuel Jáquez Leal 2010-09-24 14:43:54 UTC 
commit ff67f8492d77656de4b1ffeb2c8d97e2279630e2
Author: Chris Lord 
Date:   Fri Sep 24 09:19:59 2010 +0100

    metadata-source: Don't try to free an uninitialised pointer
    
    In grl_metadata_source_setup_full_resolution_mode, if the key-list is NULL
    then it skips to the end of the function - which frees the list and
    returns. This check happens before the list is assigned (or even, in fact,
    declare), so just return and avoid running g_list_free on uninitialised
    memory.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=630493