After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630455 - rtpbin: Handle late recv_rtp_src_events gracefully
rtpbin: Handle late recv_rtp_src_events gracefully
Status: RESOLVED INCOMPLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-09-23 18:08 UTC by Håvard Graff (hgr)
Modified: 2010-11-07 03:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (2.05 KB, patch)
2010-09-23 18:08 UTC, Håvard Graff (hgr)
none Details | Review

Description Håvard Graff (hgr) 2010-09-23 18:08:41 UTC
Created attachment 170949 [details] [review]
patch

The event could easily arrive as the rtpbin is shutting down, and
could then not find a bin and/or session.

Add locking and checking for bin and session, and keep a ref to the
pad outside the lock.

Since this is a race, it does not make sense not to handle it properly,
so g_warning is too strong. Also, when it happens, the event needs to
be unreffed.
Comment 1 Wim Taymans 2010-09-24 14:02:03 UTC
this patch does not apply, there is no on_recv_rtp_src_event in the latest git version.
Comment 2 Felipe Besoaín Pino 2010-11-07 03:33:04 UTC
Closing this bug report as no further information has been provided. Please feel free to reopen this bug if you can provide the information asked for.
Thanks!