After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630419 - Add GConf conversion script
Add GConf conversion script
Status: RESOLVED FIXED
Product: gsettings-desktop-schemas
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: gsettings-desktop-schemas-maint
gsettings-desktop-schemas-maint
Depends on:
Blocks: 628624
 
 
Reported: 2010-09-23 14:44 UTC by Bastien Nocera
Modified: 2010-10-05 09:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add GConf conversion script (7.84 KB, patch)
2010-09-23 14:44 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2010-09-23 14:44:11 UTC
As per subject
Comment 1 Bastien Nocera 2010-09-23 14:44:13 UTC
Created attachment 170918 [details] [review]
Add GConf conversion script
Comment 2 Tomas Bzatek 2010-09-23 16:41:20 UTC
Looks good, but please add ".convert" suffix to the filename to keep consistency with existing convert files (e.g. nautilus.convert, evince.convert).

The other thing is mapping enum values, as described in bug 626106 -- some asserts are expected in the current state. Later we should add enum value aliases, for org.gnome.desktop.GDesktopBackgroundShading and org.gnome.desktop.GDesktopToolbarIconSize.

I couldn't verify if it works, gsettings-data-convert throws an assert right after startup. Please run `rm ~/.local/share/gsettings-data-convert; /usr/bin/gsettings-data-convert` and watch for any problems. If it passes, feel free to commit.
Comment 3 Tomas Bzatek 2010-09-24 12:39:32 UTC
(In reply to comment #2)
> I couldn't verify if it works, gsettings-data-convert throws an assert right
> after startup. Please run `rm ~/.local/share/gsettings-data-convert;
> /usr/bin/gsettings-data-convert` and watch for any problems. If it passes, feel
> free to commit.
OK, I managed to make it working, looks like key names are all correct and there are no other errors.
Comment 4 Bastien Nocera 2010-10-05 09:31:13 UTC
Attachment 170918 [details] pushed as 9f09586 - Add GConf conversion script