After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630377 - [Patch] Add support for relative jumping
[Patch] Add support for relative jumping
Status: RESOLVED FIXED
Product: ghex
Classification: Applications
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: GHex maintainers
GHex maintainers
Depends on:
Blocks:
 
 
Reported: 2010-09-22 22:54 UTC by Roy Spliet
Modified: 2011-05-06 15:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to add relative jumping to ghex2 (1.67 KB, patch)
2010-09-22 22:54 UTC, Roy Spliet
none Details | Review
Add relative offset jumping with + and - in "Go to Byte" (2.29 KB, patch)
2011-05-06 15:25 UTC, Roy Spliet
committed Details | Review

Description Roy Spliet 2010-09-22 22:54:27 UTC
Created attachment 170871 [details] [review]
Patch to add relative jumping to ghex2

The attached patch adds support for relative jumping through the document using the "Goto byte" dialog. Starting the input with either a + or a - will make the jump relative to the cursor position instead of an absolute position.
Comment 1 Roy Spliet 2011-05-06 15:25:12 UTC
Created attachment 187362 [details] [review]
Add relative offset jumping with + and - in "Go to Byte"

Reworked patch, also checks for jumping before start of file. Applies cleanly to latest Git and compiles, but untested in this form as Fedora comes with a different version of libgconf.
Comment 2 Jonathon Jongsma 2011-05-06 15:48:02 UTC
Review of attachment 187362 [details] [review]:

Looks fine to me.