After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630353 - [appsrc] Avoid losing buffers' caps
[appsrc] Avoid losing buffers' caps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal normal
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-09-22 17:17 UTC by Thiago Sousa Santos
Modified: 2010-09-23 12:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
appsrc: Do not override buffer caps if appsrc caps is null (7.61 KB, patch)
2010-09-22 17:17 UTC, Thiago Sousa Santos 		committed Details | Review

Description Thiago Sousa Santos 2010-09-22 17:17:07 UTC 
Currently appsrc sets its 'caps' property to all buffers it pushes. This makes it erase current buffers caps when its property is NULL.

This patch makes it only set the caps if it actually has a caps to set (the property is non-NULL).
Comment 1 Thiago Sousa Santos 2010-09-22 17:17:50 UTC 
Created attachment 170848 [details] [review]
appsrc: Do not override buffer caps if appsrc caps is null

Make appsrc not set caps on buffers when its own caps is NULL.

This avoids calling make_metadata_writable on all buffers and
prevents losing buffer caps in case we are not replacing it
with something meaningful.
Comment 2 Wim Taymans 2010-09-23 08:11:55 UTC 
looks good to me!
Comment 3 Thiago Sousa Santos 2010-09-23 12:09:43 UTC 
Pushed.

commit 24b523e129d55c8ace7afdfffa341909431082e9
Author: Thiago Santos <thiago.sousa.santos@collabora.co.uk>
Date:   Wed Sep 22 14:10:18 2010 -0300

    appsrc: Do not override buffer caps if appsrc caps is null
    
    Make appsrc not set caps on buffers when its own caps is NULL.
    
    This avoids calling make_metadata_writable on all buffers and
    prevents losing buffer caps in case we are not replacing it
    with something meaningful.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=630353