After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630277 - build fixes for gnome-session against gtk3
build fixes for gnome-session against gtk3
Product: gnome-session
Classification: Core
Component: general
Other Linux
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Reported: 2010-09-21 16:57 UTC by Ray Strode [halfline]
Modified: 2010-09-21 18:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

drop use of GDK_DISPLAY() (12.07 KB, patch)
2010-09-21 16:57 UTC, Ray Strode [halfline]
none Details | Review
drop gtk_dialog_set_has_separator (... FALSE) (2.27 KB, patch)
2010-09-21 16:58 UTC, Ray Strode [halfline]
committed Details | Review
Alternative gdkdisplay patch (11.98 KB, patch)
2010-09-21 17:48 UTC, Vincent Untz
committed Details | Review

Description Ray Strode [halfline] 2010-09-21 16:57:36 UTC
Created attachment 170769 [details] [review]
drop use of GDK_DISPLAY()

I jumped on the rawhide train this morning and noticed gnome-session wasn't starting.  This is because of a few updates to gtk I think.
Comment 1 Ray Strode [halfline] 2010-09-21 16:58:06 UTC
Created attachment 170770 [details] [review]
drop gtk_dialog_set_has_separator (... FALSE)
Comment 2 Vincent Untz 2010-09-21 17:48:43 UTC
Created attachment 170773 [details] [review]
Alternative gdkdisplay patch

I'm not a big fan of the big search and replace for GDK_DISPLAY, to be honest. Here's what I had started doing. It's not complete, though (and I guess it needs to be double-checked).
Comment 3 Vincent Untz 2010-09-21 17:50:51 UTC
Comment on attachment 170770 [details] [review]
drop gtk_dialog_set_has_separator (... FALSE)

If we do this, we also need to bump the GTK+ requirement when building against GTK+ 2: we want GTK+ 2.21.x (the one where the separator got hidden by default).

Since we're frozen, though, we need to either branch or wait for after 2.32.0.

Feel free to branch if you want :-)
Comment 4 Ray Strode [halfline] 2010-09-21 18:54:44 UTC
Okay, I've done a few things here:

1) Branched gnome-2-32
2) Bumped configure on master to use 2.91.0 (which seems to be the latest in-fashion versioning scheme for 3.0)
3) Upped the required gtk2 and gtk3 versions to 2.22.0 and 2.31.7
4) Fixed up attachment 170773 [details] [review] to build and committed it (your GDK_DISPLAY() changes)
5) Committed attachment 170770 [details] [review] (my has_separator changes)
6) Changed configure to use gtk3 by default on master

hopefully I didn't screw anything up or do anything controversial.