After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630274 - Use system voice for the "starting Orca prefs for x application" message
Use system voice for the "starting Orca prefs for x application" message
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: speech
2.31.x
Other All
: Normal minor
: 2.91.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: Andalucia
 
 
Reported: 2010-09-21 16:21 UTC by Paul Hunt
Modified: 2010-10-03 13:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Hi Joanie I've tried to do a patch for this one. Hope I did it right. Both in terms of what I changed and how I made the patch. (1.03 KB, patch)
2010-09-21 16:26 UTC, Paul Hunt 		reviewed Details | Review

Description Paul Hunt 2010-09-21 16:21:13 UTC 
When the user invokes the application specific preferences dialogue we speak and braille a message saying that the dialogue is starting up.

We should be doing this using the system voice.
Comment 1 Paul Hunt 2010-09-21 16:26:10 UTC 
Created attachment 170767 [details] [review]
Hi Joanie I've tried to do a patch for this one.  Hope I did it right.  Both in terms of what I changed and how I made the patch.
Comment 2 Joanmarie Diggs (IRC: joanie) 2010-10-03 13:28:29 UTC 
Review of attachment 170767 [details] [review]:

Paul, thanks so much for the report and the fix. You indeed did everything right in terms of both the patch creation and the location of the fix. Nice job!

However, what was done for the main Orca Preferences dialog (and which you did in your patch) should not be necessary to solve the problem reported here: You cannot have app preferences without an app script. And if you have an app script, you don't need (or want) to create a new instance of the default script. You just want to use the app script's presentMessage() method.
Comment 3 Joanmarie Diggs (IRC: joanie) 2010-10-03 13:31:23 UTC 
I have just committed an alternative fix which does as I suggested in comment 2. I now hear the system voice when I get into Orca's Preferences dialog for specific applications.

http://git.gnome.org/browse/orca/commit/?id=442ed5a2d04bd201fecf4b179292615eb11b9e29