After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630216 - Use g_warning() for X errors and X IO errors
Use g_warning() for X errors and X IO errors
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: X11
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2010-09-20 22:36 UTC by Owen Taylor
Modified: 2010-09-21 04:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use g_warning() for X errors and X IO errors (2.68 KB, patch)
2010-09-20 22:36 UTC, Owen Taylor
none Details | Review

Description Owen Taylor 2010-09-20 22:36:41 UTC
Currently fprintf(stderr, ...) is used for X error and X IO errors
(unless compiled with debugging, in which case g_error() is used for
X errors.)

But if an application is redirecting log messages, we really want
X errors to appear in that same log, so it's better to use a g_logv()
variant.

Though g_warning() isn't really appropriate for "lost connection to the
server", G_LOG_LEVEL_INFO isn't part of the "prefixed log levels"
so will produce output without the application name and PID.
Comment 1 Owen Taylor 2010-09-20 22:36:43 UTC
Created attachment 170723 [details] [review]
Use g_warning() for X errors and X IO errors