After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630214 - File missing from POTFILES.in
File missing from POTFILES.in
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.31.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2010-09-20 22:24 UTC by Gabor Kelemen
Modified: 2010-09-21 07:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Trivial fix (778 bytes, patch)
2010-09-20 22:24 UTC, Gabor Kelemen 		none Details | Review

Description Gabor Kelemen 2010-09-20 22:24:23 UTC 
Created attachment 170720 [details] [review]
Trivial fix

There are some translatable (and highly visible, these are default group names in the contact list) strings in the libempathy-gtk/empathy-contact-list-store file[1], but for some reason, intltool does not report it as missing on empathy's module page[2].

As it is hard code freeze, and I don't know if fixing POTFILES.in counts as "translation and documentation", I'd rather request a permission to commit the attached fix.

[1]: http://git.gnome.org/browse/empathy/tree/libempathy-gtk/empathy-contact-list-store.h#n70
[2]: http://l10n.gnome.org/module/empathy/
Comment 1 Guillaume Desmottes 2010-09-21 07:37:22 UTC 
Ah shit :\  I'm wondering why intltool didn't detect it.

According to [1] this is not considered as a freeze breakup as this can just improve the user experience, not regress it.

I merged your patch myself to have it in ASAP and so let time to translators to update their translations.
Thanks a lot!

[1] http://mail.gnome.org/archives/gnome-i18n/2010-September/msg00017.html