After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630163 - gnome-terminal crashed with signal 5 in _XError() when Mutter is restarted
gnome-terminal crashed with signal 5 in _XError() when Mutter is restarted
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
2.31.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
: 623945 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-09-20 14:18 UTC by Chris Coulson
Modified: 2010-09-24 20:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
xtrace log (bzipped due to size) (81.84 KB, application/x-bzip)
2010-09-20 14:22 UTC, Chris Coulson
  Details
Set _NET_WM_DESKTOP on the new X window (1016 bytes, patch)
2010-09-20 14:31 UTC, Chris Coulson
reviewed Details | Review

Description Chris Coulson 2010-09-20 14:18:09 UTC
This was reported at https://launchpad.net/bugs/633303When restarting or killing mutter, gnome-terminal crashes with the following backtrace (with --sync):Breakpoint 1, gdk_x_error (display=0x9cd5d90, error=0xbff3a2ac) at /build/buildd/gtk+2.0-2.21.7/gdk/x11/gdkmain-x11.c:439439 /build/buildd/gtk+2.0-2.21.7/gdk/x11/gdkmain-x11.c: Aucun fichier ou dossier de ce type. in /build/buildd/gtk+2.0-2.21.7/gdk/x11/gdkmain-x11.c(gdb) ba#0 gdk_x_error (display=0x9cd5d90, error=0xbff3a2ac) at /build/buildd/gtk+2.0-2.21.7/gdk/x11/gdkmain-x11.c:439#1 0x0043c2c9 in _XError (dpy=0x9cd5d90, rep=0x9d34cf0) at ../../src/XlibInt.c:3103#2 0x0044299f in process_responses (dpy=0x9cd5d90, wait_for_first_event=<value optimized out>, current_error=0xbff3a3dc,    current_request=4434) at ../../src/xcb_io.c:214#3 0x00443036 in _XReply (dpy=0x9cd5d90, rep=0xbff3a410, extra=0, discard=1) at ../../src/xcb_io.c:464#4 0x00436867 in XSync (dpy=0x9cd5d90, discard=0) at ../../src/Sync.c:46#5 0x004369f5 in _XSyncFunction (dpy=0x9cd5d90) at ../../src/Synchro.c:35#6 0x00415abc in XChangeProperty (dpy=0x9cd5d90, w=48234501, property=349, type=6, format=32, mode=0, data=0xbff3a508 "",    nelements=1) at ../../src/ChProp.c:92#7 0x0806f349 in terminal_util_x11_set_net_wm_desktop (window=0x9ce8218, desktop=0) at terminal-util.c:1115#8 0x08071632 in terminal_window_composited_changed_cb (screen=0x9ce40d8, window=0x9d49088) at terminal-window.c:1689#9 0x00312a1c in g_cclosure_marshal_VOID__VOID (closure=0x9e1b578, return_value=0x0, n_param_values=1,    param_values=0x9ea9a08, invocation_hint=0xbff3a700, marshal_data=0x8071490)    at /build/buildd/glib2.0-2.25.15/gobject/gmarshal.c:79#10 0x003034b2 in g_closure_invoke (closure=0x9e1b578, return_value=0x0, n_param_values=1, param_values=0x9ea9a08,    invocation_hint=0xbff3a700) at /build/buildd/glib2.0-2.25.15/gobject/gclosure.c:766#11 0x0031c0e5 in signal_emit_unlocked_R (node=<value optimized out>, detail=<value optimized out>, instance=0x9ce40d8,    emission_return=0x0, instance_and_params=0x9ea9a08) at /build/buildd/glib2.0-2.25.15/gobject/gsignal.c:3252#12 0x0031d75c in g_signal_emit_valist (instance=0x9ce40d8, signal_id=5, detail=0, var_args=0xbff3a958 "")    at /build/buildd/glib2.0-2.25.15/gobject/gsignal.c:2983#13 0x0031da45 in g_signal_emit_by_name (instance=0x9ce40d8, detailed_signal=0x83b99d "composited-changed")    at /build/buildd/glib2.0-2.25.15/gobject/gsignal.c:3077#14 0x0080e54d in _gdk_x11_screen_process_owner_change (screen=0x9ce40d8, event=0xbff3abdc)    at /build/buildd/gtk+2.0-2.21.7/gdk/x11/gdkscreen-x11.c:1228#15 0x008016f9 in gdk_event_translate (display=<value optimized out>, event=<value optimized out>, xevent=0xbff3abdc,    return_exposes=0) at /build/buildd/gtk+2.0-2.21.7/gdk/x11/gdkevents-x11.c:2105#16 0x00801e91 in _gdk_events_queue (display=0x9ce10c0) at /build/buildd/gtk+2.0-2.21.7/gdk/x11/gdkevents-x11.c:2310#17 0x0080240f in gdk_event_dispatch (source=0x9cea330, callback=0, user_data=0x0)    at /build/buildd/gtk+2.0-2.21.7/gdk/x11/gdkevents-x11.c:2371#18 0x00ae0015 in g_main_dispatch (context=0x9cea400) at /build/buildd/glib2.0-2.25.15/glib/gmain.c:2119#19 g_main_context_dispatch (context=0x9cea400) at /build/buildd/glib2.0-2.25.15/glib/gmain.c:2672#20 0x00ae3e28 in g_main_context_iterate (context=0x9cea400, block=<value optimized out>, dispatch=1, self=0x9cbb890)    at /build/buildd/glib2.0-2.25.15/glib/gmain.c:2750#21 0x00ae4367 in g_main_loop_run (loop=0x9d270f0) at /build/buildd/glib2.0-2.25.15/glib/gmain.c:2958#22 0x00d00749 in IA__gtk_main () at /build/buildd/gtk+2.0-2.21.7/gtk/gtkmain.c:1237#23 0x0805a20d in main (argc=1, argv=0xbff3aff4) at terminal.c:592Running it through xtrace shows what is happening:The error is here:000:<:1297: 28: Request(18): ChangeProperty mode=Replace(0x00) window=0x06400103 property=0x15c("_NET_WM_DESKTOP") type=0x6("CARDINAL") data=0x00000000;000:<:1298: 4: Request(43): GetInputFocus000:>:1297:Error 3=Window: major=18, minor=0, bad=104857859...but this is the old X window, which was destroyed earlier:000:<:1028: 8: Request(4): DestroyWindow window=0x06400103000:<:1029: 4: Request(43): GetInputFocus000:>:1029: Event DestroyNotify(17) event=0x06400103 window=0x06400103000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x19b(unrecognized atom) time=0x00c10b3c state=Deleted(0x01)000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x1bd(unrecognized atom) time=0x00c10b3c state=Deleted(0x01)000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x162("_NET_WM_STATE") time=0x00c10b3c state=Deleted(0x01)000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x17a("WM_STATE") time=0x00c10b3c state=Deleted(0x01)000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x159("_NET_FRAME_EXTENTS") time=0x00c10b3c state=Deleted(0x01)000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x15c("_NET_WM_DESKTOP") time=0x00c10b3c state=Deleted(0x01)000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x1a5(unrecognized atom) time=0x00c10b3c state=Deleted(0x01)000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x23("WM_HINTS") time=0x00c10b3c state=Deleted(0x01)000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x1cb("XdndAware") time=0x00c10b3c state=Deleted(0x01)000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x1cd("_MOTIF_DRAG_RECEIVER_INFO") time=0x00c10b3c state=Deleted(0x01)000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x15d("_NET_WM_ICON") time=0x00c10b3c state=Deleted(0x01)000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x156("WM_WINDOW_ROLE") time=0x00c10b3c state=Deleted(0x01)000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x16d("_NET_WM_SYNC_REQUEST_COUNTER") time=0x00c10b3c state=Deleted(0x01)000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x16e("_NET_WM_WINDOW_TYPE") time=0x00c10b3c state=Deleted(0x01)000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x175("_NET_WM_USER_TIME_WINDOW") time=0x00c10b3c state=Deleted(0x01)000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x151("WM_CLIENT_LEADER") time=0x00c10b3c state=Deleted(0x01)000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x160("_NET_WM_PID") time=0x00c10b3c state=Deleted(0x01)000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x153("WM_LOCALE_NAME") time=0x00c10b3c state=Deleted(0x01)000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x24("WM_CLIENT_MACHINE") time=0x00c10b3c state=Deleted(0x01)000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x28("WM_NORMAL_HINTS") time=0x00c10b3c state=Deleted(0x01)000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x154("WM_PROTOCOLS") time=0x00c10b3c state=Deleted(0x01)000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x43("WM_CLASS") time=0x00c10b3c state=Deleted(0x01)000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x25("WM_ICON_NAME") time=0x00c10b3c state=Deleted(0x01)000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x15e("_NET_WM_ICON_NAME") time=0x00c10b3c state=Deleted(0x01)000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x27("WM_NAME") time=0x00c10b3c state=Deleted(0x01)000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x15f("_NET_WM_NAME") time=0x00c10b3c state=Deleted(0x01)Will attach a patch for this in a minute
Comment 1 Chris Coulson 2010-09-20 14:19:16 UTC
Urgh, what happened to all my carriage returns?
Comment 2 Chris Coulson 2010-09-20 14:22:25 UTC
Ok, trying again.

This was reported at https://launchpad.net/bugs/633303

When restarting or killing mutter, gnome-terminal crashes with the following backtrace (with --sync):

  • #0 gdk_x_error
    at /build/buildd/gtk+2.0-2.21.7/gdk/x11/gdkmain-x11.c line 439
  • #1 _XError
    at ../../src/XlibInt.c line 3103
  • #2 process_responses
    at ../../src/xcb_io.c line 214
  • #3 _XReply
    at ../../src/xcb_io.c line 464
  • #4 XSync
    at ../../src/Sync.c line 46
  • #5 _XSyncFunction
    at ../../src/Synchro.c line 35
  • #6 XChangeProperty
    at ../../src/ChProp.c line 92
  • #7 terminal_util_x11_set_net_wm_desktop
    at terminal-util.c line 1115
  • #8 terminal_window_composited_changed_cb
    at terminal-window.c line 1689
  • #9 g_cclosure_marshal_VOID__VOID
    at /build/buildd/glib2.0-2.25.15/gobject/gmarshal.c line 79
  • #10 g_closure_invoke
    at /build/buildd/glib2.0-2.25.15/gobject/gclosure.c line 766
  • #11 signal_emit_unlocked_R
    at /build/buildd/glib2.0-2.25.15/gobject/gsignal.c line 3252
  • #12 g_signal_emit_valist
    at /build/buildd/glib2.0-2.25.15/gobject/gsignal.c line 2983
  • #13 g_signal_emit_by_name
    at /build/buildd/glib2.0-2.25.15/gobject/gsignal.c line 3077
  • #14 _gdk_x11_screen_process_owner_change
    at /build/buildd/gtk+2.0-2.21.7/gdk/x11/gdkscreen-x11.c line 1228
  • #15 gdk_event_translate
    at /build/buildd/gtk+2.0-2.21.7/gdk/x11/gdkevents-x11.c line 2105
  • #16 _gdk_events_queue
    at /build/buildd/gtk+2.0-2.21.7/gdk/x11/gdkevents-x11.c line 2310
  • #17 gdk_event_dispatch
    at /build/buildd/gtk+2.0-2.21.7/gdk/x11/gdkevents-x11.c line 2371
  • #18 g_main_dispatch
    at /build/buildd/glib2.0-2.25.15/glib/gmain.c line 2119
  • #19 g_main_context_dispatch
    at /build/buildd/glib2.0-2.25.15/glib/gmain.c line 2672
  • #20 g_main_context_iterate
    at /build/buildd/glib2.0-2.25.15/glib/gmain.c line 2750
  • #21 g_main_loop_run
    at /build/buildd/glib2.0-2.25.15/glib/gmain.c line 2958
  • #22 IA__gtk_main
    at /build/buildd/gtk+2.0-2.21.7/gtk/gtkmain.c line 1237
  • #23 main
    at terminal.c line 592

Comment 3 Chris Coulson 2010-09-20 14:22:58 UTC
Created attachment 170664 [details]
xtrace log (bzipped due to size)
Comment 4 Chris Coulson 2010-09-20 14:24:27 UTC
Running through xtrace shows it fails here:

000:<:1297: 28: Request(18): ChangeProperty mode=Replace(0x00) window=0x06400103 property=0x15c("_NET_WM_DESKTOP") type=0x6("CARDINAL") data=0x00000000;
000:<:1298: 4: Request(43): GetInputFocus
000:>:1297:Error 3=Window: major=18, minor=0, bad=104857859

...but, this is the X window which has been destroyed already:

000:<:1028: 8: Request(4): DestroyWindow window=0x06400103
000:<:1029: 4: Request(43): GetInputFocus
000:>:1029: Event DestroyNotify(17) event=0x06400103 window=0x06400103
000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x19b(unrecognized atom) time=0x00c10b3c state=Deleted(0x01)
000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x1bd(unrecognized atom) time=0x00c10b3c state=Deleted(0x01)
000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x162("_NET_WM_STATE") time=0x00c10b3c state=Deleted(0x01)
000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x17a("WM_STATE") time=0x00c10b3c state=Deleted(0x01)
000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x159("_NET_FRAME_EXTENTS") time=0x00c10b3c state=Deleted(0x01)
000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x15c("_NET_WM_DESKTOP") time=0x00c10b3c state=Deleted(0x01)
000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x1a5(unrecognized atom) time=0x00c10b3c state=Deleted(0x01)
000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x23("WM_HINTS") time=0x00c10b3c state=Deleted(0x01)
000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x1cb("XdndAware") time=0x00c10b3c state=Deleted(0x01)
000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x1cd("_MOTIF_DRAG_RECEIVER_INFO") time=0x00c10b3c state=Deleted(0x01)
000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x15d("_NET_WM_ICON") time=0x00c10b3c state=Deleted(0x01)
000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x156("WM_WINDOW_ROLE") time=0x00c10b3c state=Deleted(0x01)
000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x16d("_NET_WM_SYNC_REQUEST_COUNTER") time=0x00c10b3c state=Deleted(0x01)
000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x16e("_NET_WM_WINDOW_TYPE") time=0x00c10b3c state=Deleted(0x01)
000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x175("_NET_WM_USER_TIME_WINDOW") time=0x00c10b3c state=Deleted(0x01)
000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x151("WM_CLIENT_LEADER") time=0x00c10b3c state=Deleted(0x01)
000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x160("_NET_WM_PID") time=0x00c10b3c state=Deleted(0x01)
000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x153("WM_LOCALE_NAME") time=0x00c10b3c state=Deleted(0x01)
000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x24("WM_CLIENT_MACHINE") time=0x00c10b3c state=Deleted(0x01)
000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x28("WM_NORMAL_HINTS") time=0x00c10b3c state=Deleted(0x01)
000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x154("WM_PROTOCOLS") time=0x00c10b3c state=Deleted(0x01)
000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x43("WM_CLASS") time=0x00c10b3c state=Deleted(0x01)
000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x25("WM_ICON_NAME") time=0x00c10b3c state=Deleted(0x01)
000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x15e("_NET_WM_ICON_NAME") time=0x00c10b3c state=Deleted(0x01)
000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x27("WM_NAME") time=0x00c10b3c state=Deleted(0x01)
000:>:1029: Event PropertyNotify(28) window=0x06400103 atom=0x15f("_NET_WM_NAME") time=0x00c10b3c state=Deleted(0x01)
Attaching a patch for this in a minute
Comment 5 Chris Coulson 2010-09-20 14:31:03 UTC
Created attachment 170665 [details] [review]
Set _NET_WM_DESKTOP on the new X window

Here is a patch which fixes this
Comment 6 Christian Persch 2010-09-20 15:35:59 UTC
Comment on attachment 170665 [details] [review]
Set _NET_WM_DESKTOP on the new X window

Oops; good catch! Please commit to master.
Comment 7 Christian Persch 2010-09-20 15:36:55 UTC
Comment on attachment 170665 [details] [review]
Set _NET_WM_DESKTOP on the new X window

Actually, we're in code freeze, so you need to get approval from r-t first.
Comment 8 Chris Coulson 2010-09-20 16:20:39 UTC
Ok, I got r-t approval now (http://mail.gnome.org/archives/release-team/2010-September/msg00113.html), so I've pushed to master as ecc8242.

Thanks
Comment 9 Ray Strode [halfline] 2010-09-24 20:19:56 UTC
*** Bug 623945 has been marked as a duplicate of this bug. ***