After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630150 - imapx attempts to connect to server when already cancelled
imapx attempts to connect to server when already cancelled
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Mailer
2.32.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2010-09-20 12:31 UTC by David Woodhouse
Modified: 2013-09-14 16:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.04 KB, patch)
2010-09-20 12:32 UTC, David Woodhouse 		accepted-commit_after_freeze Details | Review

Description David Woodhouse 2010-09-20 12:31:34 UTC 
camel_read() will return failure when the current operation is cancelled -- nothing is ever going to work. But imapx will happily attempt to connect to the server and start trying to authenticate, before that happens. It takes a lot of time. We should abort early.
Comment 1 David Woodhouse 2010-09-20 12:32:07 UTC 
Created attachment 170652 [details] [review]
patch
Comment 2 David Woodhouse 2010-09-20 12:32:22 UTC 
Review of attachment 170652 [details] [review]:

for 2.32 too
Comment 3 André Klapper 2010-09-21 16:52:54 UTC 
(Please change "Cancelled" to "Canceled")
Comment 4 David Woodhouse 2010-09-21 17:35:41 UTC 
There are no other instances of 'Canceled' in camel providers. There are plenty of 'Cancelled', so I've just been consistent with that.

In the 2.30 backport I've changed the string to also match the existing ones (which mostly say 'Operation cancelled').
Comment 5 Matthew Barnes 2010-09-21 18:10:54 UTC 
GIO uses "cancelled" (two L's) for all its error messages, which I'm converging on via GCancellable.  Soon there won't be any need for us to write these error messages ourselves.