After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630140 - iso8859x encoding error at buffer end, not using iconv
iso8859x encoding error at buffer end, not using iconv
Status: RESOLVED FIXED
Product: libxml2
Classification: Platform
Component: general
git master
Other Windows
: Normal normal
: ---
Assigned To: Daniel Veillard
libxml QA maintainers
Depends on:
Blocks:
 
 
Reported: 2010-09-20 10:20 UTC by Szilveszter Tóth
Modified: 2012-05-11 02:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
test.xml (to reproduce the error) (4.00 KB, text/xml)
2010-09-20 10:20 UTC, Szilveszter Tóth
  Details
Proposed patch which seems to solve this problem. (1.77 KB, patch)
2010-09-20 10:34 UTC, Szilveszter Tóth
none Details | Review

Description Szilveszter Tóth 2010-09-20 10:20:36 UTC
Created attachment 170644 [details]
test.xml (to reproduce the error)

c:\Projects\libxml2-2.7.7-snapshot\win32>bin.msvc\xmllint.exe test.xml
encoding error : output conversion failed due to conv error, bytes 0xC5 0x00 0x7
8 0x6D
I/O error : encoder error

c:\Projects\libxml2-2.7.7-snapshot\win32>

Configuration options:

cscript configure.js compiler=msvc static=yes debug=no cruntime=/MD iconv=no iso8859x=yes ftp=no http=no threads=no
Comment 1 Szilveszter Tóth 2010-09-20 10:34:03 UTC
Created attachment 170646 [details] [review]
Proposed patch which seems to solve this problem.
Comment 2 Daniel Veillard 2010-11-03 18:28:25 UTC
Okay, I can reproduce this

paphio:~/XML -> xmllint test.xml
encoding error : output conversion failed due to conv error, bytes 0xC5 0x00 0x78 0x6D
I/O error : encoder error
paphio:~/XML -> xmllint --version
xmllint: using libxml version 20707-GITv2.7.7-25-ge306260
   compiled with: Threads Tree Output Push Reader Patterns Writer SAXv1 FTP HTTP DTDValid HTML Legacy C14N Catalog XPath XPointer XInclude ISO8859X Unicode Regexps Automata Expr Schemas Schematron Modules Debug MemDebug RunDebug Zlib 
paphio:~/XML ->

but I think the patch is wrong, it actually looses characters silently, we
should not do this ... ever.
But it's a serious error so I chased it, it's actually a couple of lines
fix, which is now commited in git head,

 thanks for the report and the patch attempt !

Daniel
Comment 3 Szilveszter Tóth 2010-11-12 15:39:08 UTC
Daniel,

Many thanks for your fix, I'll check it out!

Regards,
Szilveszter
Comment 4 Szilveszter Tóth 2010-11-17 10:30:08 UTC
Thanks again! We have verified the bugfix.
Comment 5 Daniel Veillard 2012-05-11 02:12:54 UTC
Okay, marked as fixed :-)

Daniel