After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630135 - No UI feedback when imapx connection fails.
No UI feedback when imapx connection fails.
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
3.0.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2010-09-20 09:52 UTC by David Woodhouse
Modified: 2013-09-13 01:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix (1.04 KB, patch)
2010-09-20 10:27 UTC, David Woodhouse 		accepted-commit_after_freeze Details | Review

Description David Woodhouse 2010-09-20 09:52:22 UTC 
Try setting the imapx custom command to something like 'sleep 5', or connecting to a company mail server when not on the VPN.

There is *no* visible feedback that the connection failed.

On debugging imapx to check that it was returning a sensible GError, I found that it was being passed a NULL GError pointer -- the caller was discarding errors.

+ Trace 223819

  • #4 imapx_sync
    at camel-imapx-folder.c line 228
  • #5 camel_folder_sync
    at camel-folder.c line 1124
  • #6 refresh_folders_exec
    at mail-send-recv.c line 910
  • #7 mail_msg_proxy
    at mail-mt.c line 487 






Comment 1


David Woodhouse





          2010-09-20 10:27:50 UTC
        



Created attachment 170645 [details] [review]
fix

Aha, we were calling camel_operation_cancel(NULL) if the connection to the IMAP server failed. Fix that...

To ssh://dwmw2@git.gnome.org/git/evolution-data-server
   861e8ea..0739ef2  master -> master






Comment 2


David Woodhouse





          2010-09-20 10:28:01 UTC
        



Review of attachment 170645 [details] [review]:

.