GNOME Bugzilla – Bug 630091
HTML template need grand totals
Last modified: 2010-11-07 12:00:38 UTC
The original simple template had grand totals over the period by categories. This subtable was essential. Please re-introduce it.
I opened an issue in Ubuntu for the same reason: https://bugs.launchpad.net/ubuntu/+source/hamster-applet/+bug/654397 Something else. I used to export my report to PDF, with both the details and total on one page. When adding the totals again, please make it easy to generate a single page containing details and totals.
Created attachment 171677 [details] [review] Proposed fix
Review of attachment 171677 [details] [review]: thanks for the patch! please look into these issues: * you should sum up the activities for all days and group by activity and category. right now the output except for the grand total is the same as in the "totals" tab. * the grand and grand grand totals should belong to the "totals" tab. for your specific needs you could generate a report that works for your pdf-generating needs. i'm open for improvements though - not sure if tabs is the best approach here anyway, although it makes sense to some extent as on the one tab you have totals and on the other - raw data. * the en_GB locale is not essential to the commit so please exclude that file
Created attachment 171680 [details] screenshot first version I don't get your comment #1 in your review. I don't have a "totals" tab. I only have a "total by days" tab. And in the activity log, in the totals section, I group by activity and category. Attached is how it looks like on my report for september. Care to explain a bit more (I can be online if needed, lacostej on freenode or gtalk)
Created attachment 171683 [details] screenshot of repeating totals ah apologies, wrong conclusion - attached is output of my run. from the quick glimpse in the code i think you are missing sorting before groupby, as groupby does not do that for you. as for totals tab - i meant "totals by day". feel free to rename the tab and add a "totals by date" in the tab contents.
Created attachment 171684 [details] [review] Proposed fix v2 I tried to move all totals into the Totals tab. Its name changed from Totals by day to Totals and now contains both the Total by day section and Totals section.
Ah. I have to redo my commit based on your comment #6.
Created attachment 171685 [details] [review] Proposed fix v3 This one should be better. I've added sorting though I haven't tested it fully.
BTW, if you accept the patch, can you try to backport it into the version that goes into 2.32 ? That way I will have it fixed in ubuntu 10.10... Thanks
backporting to 2.30 will introduce string freeze and hard code freeze breaks, which means i'll have to get approval from the teams. i'll consider doing that. will try reviewing the patch until this evening, sorry for delay.
Just need to be backported to 2.32, not 2.30. As for the freeze, maybe considering that it was a regression (removed feature...).
Created attachment 171849 [details] [review] Add grand totals and totals by tag to html report Improved version of patch from jerome.lacoste - add totals by tag
Toms, what can we do to get this regression fixed ? My main focus is to get the totals back. Don't need the totals by tag now nor anything that would cause adding new strings. We may want to split this patch into enhancement & regression fixes. I would really like this to be backported in 2.32 branch and end up in Ubuntu 10.10.
nyah, sorry for delay. i will be giving shout to the release team about breaking freeze. the next release (2.32.1) is in Nov 15, so will get it in by then. until then just bit of patience - haven't forgotten the bug, just super swamped at the moment (ends this week)
ok. Just give feedback on the patches when you have time.
Review of attachment 171685 [details] [review]: cheers
Review of attachment 171849 [details] [review]: fix pushed to git master for now
got two approvals from i18n[1] and no response from release team (guess that's because this is a regression). pushed fix to gnome-2-32. thank you everyone! [1] http://mail.gnome.org/archives/gnome-i18n/2010-November/msg00061.html