Bug 630033 - Improve tests for X error traps, fix two bugs
Improve tests for X error traps, fix two bugs
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2010-09-19 00:59 UTC by Havoc Pennington
Modified: 2010-09-19 03:04 UTC (History)
1 user (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
Improve tests for X error traps, fix two bugs (6.17 KB, patch)
2010-09-19 00:59 UTC, Havoc Pennington 		none Details | Diff | Review
View All Add an attachment (proposed patch, testcase, etc.)

Description Havoc Pennington 2010-09-19 00:59:47 UTC 
Couple bugs, and more thorough test.

Depends on fix for bug 630032
Comment 1 Havoc Pennington 2010-09-19 00:59:49 UTC 
Created attachment 170575 [details] [review]
Improve tests for X error traps, fix two bugs

* don't lose track of previous X error handler
  if nested traps are pushed
* free any remaining traps when display
  is finalized

Test will fail unless bug 630032 is closed so
gdk_display_close() works.
Comment 2 Matthias Clasen 2010-09-19 03:04:40 UTC 
thanks, committed
Note You need to log in before you can comment on or make changes to this bug.