After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 629988 - Distribution check in configure broken when building openSUSE packages
Distribution check in configure broken when building openSUSE packages
Status: RESOLVED FIXED
Product: aisleriot
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: aisleriot-maint
aisleriot-maint
Depends on:
Blocks:
 
 
Reported: 2010-09-18 12:53 UTC by Vincent Untz
Modified: 2011-12-03 18:20 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Vincent Untz 2010-09-18 12:53:14 UTC
The checks in configure that look for the LSB distribution name are broken when we build openSUSE packages. LSB_DISTRIBUTION is used, but LSB_DISTRIBUTOR is what would work in openSUSE.

The reason is that LSB_DISTRIBUTION contains the specific version of a distro. However, when we build openSUSE packages, we don't have access to this information.
Comment 1 Christian Persch 2010-09-19 12:33:26 UTC
What's the output of lsb-release -s -i and lsb-release -s -d in this case?
Comment 2 Vincent Untz 2010-09-19 12:53:48 UTC
# lsb_release -s -i
SUSE LINUX
# lsb_release -s -d
"Dummy Product (i586)"

Note that it's what we get on a build system -- not what we get on the user system. In that case, we get:

# lsb_release -s -i
SUSE LINUX
# lsb_release -s -d
"openSUSE 11.4 Milestone 1 of 6 (i586)"
Comment 3 Christian Persch 2011-02-25 18:18:03 UTC
I feel this is a problem on the builders; they clearly should set lsb-release to something sensible that indicates that it's suse-derived.
Comment 4 Christian Persch 2011-05-01 12:15:04 UTC
-> aisleriot
Comment 5 Christian Persch 2011-10-05 20:28:03 UTC
Vincent: any chance of getting this fixed in the build system as per comment 3?
Comment 6 Vincent Untz 2011-10-05 20:49:25 UTC
Unfortunately, I don't think we can change this in the build system, due to the way things work there (changing the distributor version would trigger a rebuild of aisleriot, which we don't want).
Comment 7 Christian Persch 2011-10-05 22:30:05 UTC
So how about a --with-packagekit-distro-id-whatever configure switch?
Comment 8 Vincent Untz 2011-10-06 07:21:09 UTC
That would surely works, but I do think it's wrong to use the description the way it's done here. Looking at the example in the lsb_release man page, the description is really free-style.
Comment 9 Christian Persch 2011-12-03 18:20:17 UTC
On master, I change the checks to use the concatenation of the -d and -i strings, and the result is only used anymore to pre-guess the correct card theme paths; the packagekit integration is now done independently of this. Since that's the best we can do here AFAICS, I'm closing this. Reopen if you disagree / have a better solution :-)