GNOME Bugzilla – Bug 629988
Distribution check in configure broken when building openSUSE packages
Last modified: 2011-12-03 18:20:17 UTC
The checks in configure that look for the LSB distribution name are broken when we build openSUSE packages. LSB_DISTRIBUTION is used, but LSB_DISTRIBUTOR is what would work in openSUSE. The reason is that LSB_DISTRIBUTION contains the specific version of a distro. However, when we build openSUSE packages, we don't have access to this information.
What's the output of lsb-release -s -i and lsb-release -s -d in this case?
# lsb_release -s -i SUSE LINUX # lsb_release -s -d "Dummy Product (i586)" Note that it's what we get on a build system -- not what we get on the user system. In that case, we get: # lsb_release -s -i SUSE LINUX # lsb_release -s -d "openSUSE 11.4 Milestone 1 of 6 (i586)"
I feel this is a problem on the builders; they clearly should set lsb-release to something sensible that indicates that it's suse-derived.
-> aisleriot
Vincent: any chance of getting this fixed in the build system as per comment 3?
Unfortunately, I don't think we can change this in the build system, due to the way things work there (changing the distributor version would trigger a rebuild of aisleriot, which we don't want).
So how about a --with-packagekit-distro-id-whatever configure switch?
That would surely works, but I do think it's wrong to use the description the way it's done here. Looking at the example in the lsb_release man page, the description is really free-style.
On master, I change the checks to use the concatenation of the -d and -i strings, and the result is only used anymore to pre-guess the correct card theme paths; the packagekit integration is now done independently of this. Since that's the best we can do here AFAICS, I'm closing this. Reopen if you disagree / have a better solution :-)