After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 629967 - dbus: Restore the previous behavior of returning undefined
dbus: Restore the previous behavior of returning undefined
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2010-09-17 23:54 UTC by Johan Bilien
Modified: 2010-09-18 00:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dbus: Restore the previous behavior of returning undefined (1.12 KB, patch)
2010-09-17 23:54 UTC, Johan Bilien 		committed Details | Review

Description Johan Bilien 2010-09-17 23:54:40 UTC 
for methods with an empty out signature.

I broke this with https://bugzilla.gnome.org/show_bug.cgi?id=629965
Comment 1 Johan Bilien 2010-09-17 23:54:42 UTC 
Created attachment 170523 [details] [review]
dbus: Restore the previous behavior of returning undefined
Comment 2 Colin Walters 2010-09-17 23:57:11 UTC 
Review of attachment 170523 [details] [review]:

So this code was working around the old broken code?  Looks OK I guess.
Comment 3 Johan Bilien 2010-09-18 00:17:22 UTC 
We have tests and maybe users of the API which expect that. Maybe we should just always return an array of arguments.