GNOME Bugzilla – Bug 629954
improve the appearance of the universal access menu
Last modified: 2010-09-22 15:13:23 UTC
Created attachment 170512 [details] screenshot of master Nice work getting the new universal access menu landed. However, it isn't quite up to par visually. Our current visual design target is: http://live.gnome.org/GnomeShell/Design/Guidelines/SystemStatus/UniversalAccess I'll cc jimmac in case he has an update for that. I'll attach what it looks like in master now. * fix spacing between label and swich * improve the style of the switch itself * fix the capitalization inconsistencies * fix the font style/color issues
the switches are easy to fix once we get svgs for them
I've created two alternatives to the widget, but it will only work on a black/dark background. http://git.gnome.org/browse/gnome-shell-design/plain/assets/toggle-dark-us.svg http://git.gnome.org/browse/gnome-shell-design/plain/assets/toggle-dark-international.svg If the widget is supposed to work on any background, it will need to change its colors. I've included a sample rendering of how it might look good on a light background. Is the toggle animated? Does it work with either a click or a drag? If so, it should light up blue (blend, 100ms) only after the slider is in place.
(In reply to comment #2) > Is the toggle animated? Does it work with either a click or a drag? At the moment the answers are no and no, but I don't know if that was the intent or not. See the questions on http://live.gnome.org/GnomeShell/Design/Guidelines/SystemStatus/UniversalAccess.
Created attachment 170550 [details] [review] Fix the universal access menu text to match mockups This makes the menu label text more closely match the mockups http://live.gnome.org/GnomeShell/Design/Guidelines/SystemStatus/UniversalAccess
Created attachment 170551 [details] [review] Fix spacing for switch menu items
Created attachment 170552 [details] [review] Style fixes for the popup menu
These don't add the new svg but do remove the temporary css/ascii drawing.
What's the plan regarding the size of the font? Shouldn't it be the same as GTK+ apps? It looks out of place ATM.
Review of attachment 170550 [details] [review]: This needs input from the desig... err ;)
Review of attachment 170551 [details] [review]: "Fix spacing" doesn't mean much by itself maybe a short commit message is needed.
Review of attachment 170552 [details] [review]: Assuming you like the new style this is fine as well.
Still need to add the new svg.
Created attachment 170759 [details] [review] PopupSwitchMenuItem: use SVG switches
(In reply to comment #13) > Created an attachment (id=170759) [details] [review] > PopupSwitchMenuItem: use SVG switches Looks nice. Thanks Dan.
Review of attachment 170759 [details] [review]: I'm a bit worried that the us/intl split will result in requests to add more localized SVGs for languages with sufficiently short translations of "ON"/"OFF", but well ... Code looks good.
i think that's everything then Attachment 170759 [details] pushed as d188a7b - PopupSwitchMenuItem: use SVG switches