GNOME Bugzilla – Bug 629933
Missing return value
Last modified: 2010-09-18 08:14:45 UTC
I: A function uses a 'return;' statement, but has actually a value to return, like an integer ('return 42;') or similar. W: libgee voidreturn linkedlist.c:726
Thanks for taking the time to report this bug. This bug report isn't very useful because it doesn't describe the bug well. If you have time and can still reproduce the bug, please read http://bugzilla.gnome.org/bug-HOWTO.html and add a more useful description to this bug. I'd be mostly interested in: - linkedlist.c (it is not in git and it is generated by Vala) - Version of vala - Version of compiler Full build log would be mostly helpful. PS. It looks like either bug of vala or using unsupported compiler by vala. Either way - it looks like vala problem but I cannot say without above informations.
public override G remove_at (int index) { assert (index >= 0); assert (index < this._size); unowned Node<G>? n = this._get_node_at (index); return_if_fail (n != null); G element = n.data; this._remove_node (n); return element; } The return_if_fail should be a return_val_if_fail.
commit 235d9b0410b68062911c414badf9a94bce1d34b6 Author: Maciej Piechotka <uzytkownik2@gmail.com> Date: Sat Sep 18 09:10:05 2010 +0100 Change return_if_fail into assert in remove_at of LinkedList. It fixes build issue described in bug #629933 and make the behavior compatible with ArrayList. commit 11e19cc2183c0bb9871b70ab62e34b6cd3702e95 Author: Maciej Piechotka <uzytkownik2@gmail.com> Date: Sat Sep 18 09:10:05 2010 +0100 Change return_if_fail into assert in remove_at of LinkedList. It fixes build issue described in bug #629933 and make the behavior compatible with ArrayList.