After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 629882 - Add libORBit2-devel to required packages
Add libORBit2-devel to required packages
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: building
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-09-16 23:00 UTC by Milan Bouchet-Valat
Modified: 2010-09-28 19:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add libORBit2-devel to required packages (4.06 KB, patch)
2010-09-16 23:00 UTC, Milan Bouchet-Valat 		committed Details | Review

Description Milan Bouchet-Valat 2010-09-16 23:00:35 UTC 
Feels weird to me that we didn't notice this earlier, but I've reinstalled my system from scratch and I got an error...

Note it would be good to check that package names for distributions other than Debian are correct, because they are really messy and Google may be wrong!
Comment 1 Milan Bouchet-Valat 2010-09-16 23:00:38 UTC 
Created attachment 170443 [details] [review]
Add libORBit2-devel to required packages

GConf requires it to build, it's been forgotten when we introduced
it into the moduleset. Debian uses 'liborbit2-dev', Fedora
'libORBit2-devel', SuSE 'orbit2-devel' and Mandriva 'ORBit2-devel'.
Comment 2 Owen Taylor 2010-09-17 11:57:59 UTC 
Review of attachment 170443 [details] [review]:

OK to commit if you fix the package name for Fedora; the SuSE and Mandrake packages aren't up-to-date anyways, so introducing a bug in there would probably be a good thing, since it would force someone using that system to look at the script and maybe fix it up :-)

::: tools/build/gnome-shell-build-setup.sh
@@ +104,3 @@
     automake bison flex gettext git gnome-common gnome-doc-utils gvfs intltool
     libtool pkgconfig dbus-glib-devel gnome-desktop-devel gnome-menus-devel
+    gnome-python2-gconf jasper-devel libffi-devel libjpeg-devel libORBit2-devel

This is wrong - it's ORBit2-devel for Fedora
Comment 3 Milan Bouchet-Valat 2010-09-17 13:57:47 UTC 
(In reply to comment #2)
> Review of attachment 170443 [details] [review]:
> 
> OK to commit if you fix the package name for Fedora; the SuSE and Mandrake
> packages aren't up-to-date anyways, so introducing a bug in there would
> probably be a good thing, since it would force someone using that system to
> look at the script and maybe fix it up :-)
Interesting. I'd rather get the package names right, though... ;-)

> ::: tools/build/gnome-shell-build-setup.sh
> @@ +104,3 @@
>      automake bison flex gettext git gnome-common gnome-doc-utils gvfs intltool
>      libtool pkgconfig dbus-glib-devel gnome-desktop-devel gnome-menus-devel
> +    gnome-python2-gconf jasper-devel libffi-devel libjpeg-devel
> libORBit2-devel
> 
> This is wrong - it's ORBit2-devel for Fedora
My bad! I must have Googled too quickly... But I was good at warning you, at least!

Pushed with the fix as 6f75c8c.
Comment 4 André Klapper 2010-09-28 18:39:15 UTC 
(In reply to comment #1)
> Created an attachment (id=170443) [details] [review]
> Add libORBit2-devel to required packages
> 
> GConf requires it to build

So after migrating gnome-shell to GSettings both gconf and orbit dependencies can be removed again, right? If so, why is bug 617917 closed as FIXED?
Comment 5 Owen Taylor 2010-09-28 19:19:48 UTC 
(In reply to comment #4)
> (In reply to comment #1)
> > Created an attachment (id=170443) [details] [review] [details] [review]
> > Add libORBit2-devel to required packages
> > 
> > GConf requires it to build
> 
> So after migrating gnome-shell to GSettings both gconf and orbit dependencies
> can be removed again, right? If so, why is bug 617917 closed as FIXED?

There's still a lot of stuff using GConf (mutter, bits of gnome, etc.)