After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 629862 - Add tests for the key-file backend
Add tests for the key-file backend
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: Key file backend
git master
Other All
: Normal enhancement
: gnome-3.0
Assigned To: folks-maint
folks-maint
Depends on: 629081
Blocks:
 
 
Reported: 2010-09-16 16:31 UTC by Philip Withnall
Modified: 2010-11-04 00:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Squashed diff of the 629862-key-file-tests branch (30.13 KB, patch)
2010-09-16 16:33 UTC, Philip Withnall
none Details | Review
Squashed diff of the 629862-key-file-tests branch (updated) (31.45 KB, patch)
2010-09-17 09:55 UTC, Philip Withnall
none Details | Review

Description Philip Withnall 2010-09-16 16:31:28 UTC
Branch coming up which reorganises the test framework a bit and adds some basic key-file tests.
Comment 1 Philip Withnall 2010-09-16 16:33:10 UTC
Created attachment 170426 [details] [review]
Squashed diff of the 629862-key-file-tests branch

http://git.collabora.co.uk/?p=user/pwith/folks;a=shortlog;h=refs/heads/629862-key-file-tests
Comment 2 Philip Withnall 2010-09-16 16:35:31 UTC
This branch is based on the branch for bug #629081, which I needed to disable the Telepathy backend. I've just realised I didn't actually make proper use of it in this branch, though, so I'll push an extra commit to the branch which disables the Telepathy backend in the key-file tests.
Comment 3 Philip Withnall 2010-09-17 09:55:45 UTC
Created attachment 170472 [details] [review]
Squashed diff of the 629862-key-file-tests branch (updated)

http://git.collabora.co.uk/?p=user/pwith/folks;a=shortlog;h=refs/heads/629862-key-file-tests

Updated to go with the updated branch in bug #629081, and also to fix a few bugs.
Comment 4 Travis Reitter 2010-11-04 00:44:12 UTC
Merged:

commit 145d13ad7320affbdc5f8c201c75251f8cd6c6ac
Author: Philip Withnall <philip.withnall@collabora.co.uk>
Date:   Thu Sep 16 17:46:32 2010 +0100

    Disable unused backends in the tests.
    
    Helps bgo#629862.

 tests/key-file/individual-retrieval.vala  |   20 ++++++++++++++++++++
 tests/telepathy/individual-retrieval.vala |    8 ++++++++
 2 files changed, 28 insertions(+), 0 deletions(-)

commit 714e0d69ec716e80f48dfbb000bda5f9dacb0aa5
Author: Philip Withnall <philip.withnall@collabora.co.uk>
Date:   Thu Sep 16 15:00:04 2010 +0100

    Add some initial key-file backend tests
    
    Fixes bgo#629862.

 NEWS                                     |    1 +
 configure.ac                             |    1 +
 tests/Makefile.am                        |    1 +
 tests/key-file/Makefile.am               |   50 ++++++++++
 tests/key-file/individual-retrieval.vala |  156 ++++++++++++++++++++++++++++++
 5 files changed, 209 insertions(+), 0 deletions(-)

commit db13eb9b9d8788d58ef4ad102337ea315202c03c
Author: Philip Withnall <philip.withnall@collabora.co.uk>
Date:   Thu Sep 16 14:29:03 2010 +0100

    Add a key-file test library
    
    This contains some of the boilerplate code necessary to test the key-file
    backend with arbitrary key files.
    
    Helps bgo#629862.

 configure.ac                    |    1 +
 tests/lib/Makefile.am           |    1 +
 tests/lib/key-file/Makefile.am  |   31 +++++++++++++++++++++
 tests/lib/key-file/backend.vala |   57 +++++++++++++++++++++++++++++++++++++++
 4 files changed, 90 insertions(+), 0 deletions(-)