After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 629779 - introspection does not build with g-i 0.9.5
introspection does not build with g-i 0.9.5
Status: RESOLVED FIXED
Product: libgda
Classification: Other
Component: general
4.1.x
Other Linux
: Normal normal
: ---
Assigned To: malerba
gnome-db Maintainers
: 629391 (view as bug list)
Depends on: 629682
Blocks:
 
 
Reported: 2010-09-15 16:42 UTC by Götz Waschk
Modified: 2011-06-20 08:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
workaround in g-i (1.26 KB, patch)
2010-09-18 17:52 UTC, Vincent Untz 		none Details | Review

Description Götz Waschk 2010-09-15 16:42:00 UTC 
This is with libgda 4.1.11 and gobject-introspection 0.9.5:

  CCLD   libgda-4.0.la
  GICOMP Gda-4.0.gir
Gda-4.0.gir:22:50: error: The element <type> is invalid here
Comment 1 malerba 2010-09-15 18:53:24 UTC 
I know about that bug, see introspection bug #629682.
For Libgda V5, which will link with gtk3 and related libraries, I've remove the GdaValueList typedef which is the problem since anyway it's useless, but I can't do it for the upcoming 4.2 because that would break the API & ABI.

I don't right now have the correct gobject-introspection version to test, but can you try to replace in libgda/gda-value.h:

typedef GList GdaValueList;
by:
#define GdaValueList GList

If it's Ok, I'll include this correction in the next release.
Comment 2 Götz Waschk 2010-09-15 19:33:09 UTC 
I get the same error with that modification.
Comment 3 malerba 2010-09-17 17:20:36 UTC 
*** Bug 629391 has been marked as a duplicate of this bug. ***
Comment 4 Vincent Untz 2010-09-18 16:35:21 UTC 
We probably just need a workaround in g-i :/
Comment 5 Vincent Untz 2010-09-18 17:52:44 UTC 
Created attachment 170555 [details] [review]
workaround in g-i

This is patch that works for me.

I must admit I don't really understand why we have GdaSList :-)
Comment 6 David Ronis 2010-09-19 16:07:04 UTC 
I applied the patch (to g-i-0.9.6) and reinstalled.   The hack worked.

Thanks
Comment 7 Andrew Starr-Bochicchio 2010-12-13 16:48:40 UTC 
/usr/bin/g-ir-compiler --includedir=. --includedir=. Gda-4.0.gir -o Gda-4.0.typelib
Gda-4.0.gir:22:50: error: The element <type> is invalid here
error parsing file Gda-4.0.gir: The element <type> is invalid here

Was the workaround actually applied to g-i? I'm still seeing this trying to build libgda 4.2.2 against g-i 0.9.12+git20101124-0ubuntu3 on Ubuntu natty.
Comment 8 André Klapper 2010-12-13 16:55:23 UTC 
(In reply to comment #7)
> Was the workaround actually applied to g-i?

Bug status is NEW and not FIXED, hence no.
Comment 9 Murray Cumming 2010-12-15 14:27:52 UTC 
> typedef GList GdaValueList;
> by:
> #define GdaValueList GList

I agree with Vincent. I don't see why this is needed anyway. Maybe it's just an attempt to keep API compared with some version that had GdaValueList that wasn't just a GList.

Regardless of this introspection stuff, I'd like to just use GList everywhere, keeping the typedef around for compatibility, but deprecating it.
Comment 10 Murray Cumming 2011-06-16 12:07:53 UTC 
There is no GdaValueList in master (libgda-5.0).
Comment 11 Murray Cumming 2011-06-20 08:35:13 UTC 
Please reopen if this is still a problem.