After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 629707 - Missing msgctxt for translatable "Select" string
Missing msgctxt for translatable "Select" string
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.31.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2010-09-14 20:16 UTC by Milo Casagrande
Modified: 2010-09-29 10:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
http://git.Collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/string-ctx-629707 (592 bytes, patch)
2010-09-15 11:10 UTC, Guillaume Desmottes
rejected Details | Review
http://git.Collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/string-ctx-629707 (1.21 KB, patch)
2010-09-15 11:14 UTC, Guillaume Desmottes
rejected Details | Review
http://git.Collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/string-ctx-629707 (1.29 KB, patch)
2010-09-15 11:19 UTC, Guillaume Desmottes
accepted-commit_after_freeze Details | Review

Description Milo Casagrande 2010-09-14 20:16:07 UTC
While translating Empathy I found a string that is used in two different contexts, and that can be of concern to translators if in their language they need to differentiate the translation.

The stirng is located in:

libempathy-gtk/empathy-groups-widget.c
column = gtk_tree_view_column_new_with_attributes (_("Select"), renderer ...

and in:
libempathy-gtk/empathy-irc-network-chooser-dialog.c
priv->select_button = gtk_dialog_add_button (dialog, _("Select"), ...

The first one is the header of a column, the second one a button.
Is it possible to have a msgctxt for both of them?

I think it is necessary to ask for a string-freeze break if we want this to be shipped with 2.32.

Thanks.
Comment 1 Guillaume Desmottes 2010-09-15 11:10:10 UTC
Created attachment 170326 [details] [review]
http://git.Collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/string-ctx-629707

 libempathy-gtk/empathy-groups-widget.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Comment 2 Guillaume Desmottes 2010-09-15 11:14:27 UTC
Created attachment 170327 [details] [review]
http://git.Collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/string-ctx-629707

 libempathy-gtk/empathy-groups-widget.c             |    3 ++-
 .../empathy-irc-network-chooser-dialog.c           |    2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)
Comment 3 Guillaume Desmottes 2010-09-15 11:19:03 UTC
Created attachment 170328 [details] [review]
http://git.Collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/string-ctx-629707

 libempathy-gtk/empathy-groups-widget.c             |    3 ++-
 .../empathy-irc-network-chooser-dialog.c           |    3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)
Comment 4 Guillaume Desmottes 2010-09-15 11:20:26 UTC
Comment on attachment 170328 [details] [review]
http://git.Collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/string-ctx-629707

Reviewed by Philip. I'll merge once I get the approval of the RT.
Comment 5 Guillaume Desmottes 2010-09-29 10:51:31 UTC
Merged to master, will be in 2.91.0.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.