After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 629694 - Importing a source which has already been imported raises an error and the import process doesn't continue
Importing a source which has already been imported raises an error and the im...
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: Media library
Git
Other Linux
: Normal normal
: 0.14
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2010-09-14 17:55 UTC by Thibault Saunier
Modified: 2010-10-01 12:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Do things as I think they should be. (811 bytes, patch)
2010-09-14 17:55 UTC, Thibault Saunier 		rejected Details | Review

Description Thibault Saunier 2010-09-14 17:55:20 UTC 
Created attachment 170266 [details] [review]
Do things as I think they should be.

I don't understand why it acts like that, is it a choice?

I would not import anything and close the importing dialog because when you import several sources it is pretty strange, and annoying.
Comment 1 Jean-François Fortin Tam 2010-09-24 13:51:59 UTC 
The behavior I currently see is that the import dialog closes, but closes without completing: if there is an "already present" clip among those being imported, it stops right there and doesn't continue importing the other clips afterwards.

Does your patch fix that, or did I misunderstand the issue?
Comment 2 Jean-François Fortin Tam 2010-09-24 13:56:38 UTC 
Seems to work better for me with Thibault's patch; retitling for clarity. Don't know if there are unforeseen consequences though.
Comment 3 Jean-François Fortin Tam 2010-09-24 15:56:07 UTC 
See also: https://bugs.launchpad.net/ubuntu/+source/pitivi/+bug/638278 which seems to be a slightly different bug but probably affected by this.
Comment 4 Alessandro Decina 2010-10-01 12:49:48 UTC 
commit 0c14c4115fa4451b1769cf54fb3aacd80d7cb6a0
Author: Luis de Bethencourt <luis@debethencourt.com>
Date:   Wed Sep 22 17:04:43 2010 +0200

    ui/sourcelist: catch the error of addUris(files) if file is already imported into the sourcelist of the project.