GNOME Bugzilla – Bug 629694
Importing a source which has already been imported raises an error and the import process doesn't continue
Last modified: 2010-10-01 12:51:39 UTC
Created attachment 170266 [details] [review] Do things as I think they should be. I don't understand why it acts like that, is it a choice? I would not import anything and close the importing dialog because when you import several sources it is pretty strange, and annoying.
The behavior I currently see is that the import dialog closes, but closes without completing: if there is an "already present" clip among those being imported, it stops right there and doesn't continue importing the other clips afterwards. Does your patch fix that, or did I misunderstand the issue?
Seems to work better for me with Thibault's patch; retitling for clarity. Don't know if there are unforeseen consequences though.
See also: https://bugs.launchpad.net/ubuntu/+source/pitivi/+bug/638278 which seems to be a slightly different bug but probably affected by this.
commit 0c14c4115fa4451b1769cf54fb3aacd80d7cb6a0 Author: Luis de Bethencourt <luis@debethencourt.com> Date: Wed Sep 22 17:04:43 2010 +0200 ui/sourcelist: catch the error of addUris(files) if file is already imported into the sourcelist of the project.